[Intel-wired-lan] [PATCH v2 3/3] net: ethernet: move from strlcpy with unused retval to strscpy

naamax.meir naamax.meir at linux.intel.com
Sat Sep 17 21:54:27 PDT 2022


On 8/30/2022 23:14, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
> 
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <wsa+renesas at sang-engineering.com>
> Reviewed-by: Petr Machata <petrm at nvidia.com> # For drivers/net/ethernet/mellanox/mlxsw
> Acked-by: Geoff Levand <geoff at infradead.org> # For ps3_gelic_net and spider_net_ethtool
> Acked-by: Tom Lendacky <thomas.lendacky at amd.com> # For drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
> Acked-by: Marcin Wojtas <mw at semihalf.com> # For drivers/net/ethernet/marvell/mvpp2
> Reviewed-by: Leon Romanovsky <leonro at nvidia.com> # For drivers/net/ethernet/mellanox/mlx{4|5}
> Reviewed-by: Shay Agroskin <shayagr at amazon.com> # For drivers/net/ethernet/amazon/ena
> Acked-by: Krzysztof Hałasa <khalasa at piap.pl> # For IXP4xx Ethernet
> ---
> 
> Changes since v1:
> * split into smaller patches
> * added given tags
> 
>   drivers/net/ethernet/3com/3c509.c                |  2 +-
>   drivers/net/ethernet/3com/3c515.c                |  2 +-
>   drivers/net/ethernet/3com/3c589_cs.c             |  2 +-
>   drivers/net/ethernet/3com/3c59x.c                |  6 +++---
>   drivers/net/ethernet/3com/typhoon.c              |  8 ++++----
>   drivers/net/ethernet/8390/ax88796.c              |  6 +++---
>   drivers/net/ethernet/8390/etherh.c               |  6 +++---
>   drivers/net/ethernet/adaptec/starfire.c          |  4 ++--
>   drivers/net/ethernet/aeroflex/greth.c            |  4 ++--
>   drivers/net/ethernet/agere/et131x.c              |  4 ++--
>   drivers/net/ethernet/alacritech/slicoss.c        |  4 ++--
>   drivers/net/ethernet/allwinner/sun4i-emac.c      |  4 ++--
>   drivers/net/ethernet/alteon/acenic.c             |  4 ++--
>   drivers/net/ethernet/amazon/ena/ena_ethtool.c    |  4 ++--
>   drivers/net/ethernet/amazon/ena/ena_netdev.c     |  2 +-
>   drivers/net/ethernet/amd/amd8111e.c              |  4 ++--
>   drivers/net/ethernet/amd/au1000_eth.c            |  2 +-
>   drivers/net/ethernet/amd/nmclan_cs.c             |  2 +-
>   drivers/net/ethernet/amd/pcnet32.c               |  4 ++--
>   drivers/net/ethernet/amd/sunlance.c              |  2 +-
>   drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c     |  4 ++--
>   .../net/ethernet/aquantia/atlantic/aq_ethtool.c  |  2 +-
>   drivers/net/ethernet/arc/emac_main.c             |  2 +-
>   drivers/net/ethernet/atheros/ag71xx.c            |  4 ++--
>   .../net/ethernet/atheros/atl1c/atl1c_ethtool.c   |  4 ++--
>   .../net/ethernet/atheros/atl1e/atl1e_ethtool.c   |  6 +++---
>   drivers/net/ethernet/atheros/atlx/atl1.c         |  4 ++--
>   drivers/net/ethernet/atheros/atlx/atl2.c         |  6 +++---
>   drivers/net/ethernet/broadcom/b44.c              |  6 +++---
>   drivers/net/ethernet/broadcom/bcm63xx_enet.c     |  4 ++--
>   drivers/net/ethernet/broadcom/bcmsysport.c       |  4 ++--
>   drivers/net/ethernet/broadcom/bgmac.c            |  6 +++---
>   drivers/net/ethernet/broadcom/bnx2.c             |  6 +++---
>   drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c  |  2 +-
>   .../net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c  |  6 +++---
>   drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c |  2 +-
>   .../net/ethernet/broadcom/bnx2x/bnx2x_sriov.h    |  2 +-
>   drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c |  2 +-
>   .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c    |  8 ++++----
>   drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c    |  2 +-
>   drivers/net/ethernet/broadcom/genet/bcmgenet.c   |  2 +-
>   drivers/net/ethernet/broadcom/tg3.c              |  6 +++---
>   drivers/net/ethernet/brocade/bna/bnad_ethtool.c  |  6 +++---
>   drivers/net/ethernet/cavium/octeon/octeon_mgmt.c |  2 +-
>   .../net/ethernet/cavium/thunder/nicvf_ethtool.c  |  4 ++--
>   drivers/net/ethernet/chelsio/cxgb/cxgb2.c        |  4 ++--
>   drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c  |  4 ++--
>   .../net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c   |  4 ++--
>   drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c  |  4 ++--
>   .../net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c  |  4 ++--
>   .../chelsio/inline_crypto/chtls/chtls_main.c     |  2 +-
>   drivers/net/ethernet/cirrus/ep93xx_eth.c         |  2 +-
>   drivers/net/ethernet/cisco/enic/enic_ethtool.c   |  6 +++---
>   drivers/net/ethernet/davicom/dm9000.c            |  4 ++--
>   drivers/net/ethernet/dec/tulip/de2104x.c         |  4 ++--
>   drivers/net/ethernet/dec/tulip/dmfe.c            |  4 ++--
>   drivers/net/ethernet/dec/tulip/tulip_core.c      |  4 ++--
>   drivers/net/ethernet/dec/tulip/uli526x.c         |  4 ++--
>   drivers/net/ethernet/dec/tulip/winbond-840.c     |  4 ++--
>   drivers/net/ethernet/dlink/dl2k.c                |  4 ++--
>   drivers/net/ethernet/dlink/sundance.c            |  4 ++--
>   drivers/net/ethernet/dnet.c                      |  4 ++--
>   drivers/net/ethernet/emulex/benet/be_cmds.c      | 12 ++++++------
>   drivers/net/ethernet/emulex/benet/be_ethtool.c   |  6 +++---
>   drivers/net/ethernet/faraday/ftgmac100.c         |  4 ++--
>   drivers/net/ethernet/faraday/ftmac100.c          |  4 ++--
>   drivers/net/ethernet/fealnx.c                    |  4 ++--
>   .../net/ethernet/freescale/dpaa/dpaa_ethtool.c   |  4 ++--
>   drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c |  2 +-
>   .../net/ethernet/freescale/enetc/enetc_ethtool.c |  4 ++--
>   drivers/net/ethernet/freescale/fec_main.c        |  8 ++++----
>   drivers/net/ethernet/freescale/fec_ptp.c         |  2 +-
>   .../ethernet/freescale/fs_enet/fs_enet-main.c    |  2 +-
>   drivers/net/ethernet/freescale/gianfar_ethtool.c |  2 +-
>   .../net/ethernet/freescale/ucc_geth_ethtool.c    |  4 ++--
>   drivers/net/ethernet/fujitsu/fmvj18x_cs.c        |  4 ++--
>   drivers/net/ethernet/hisilicon/hip04_eth.c       |  4 ++--
>   drivers/net/ethernet/ibm/ehea/ehea_ethtool.c     |  4 ++--
>   drivers/net/ethernet/ibm/emac/core.c             |  4 ++--
>   drivers/net/ethernet/ibm/ibmveth.c               |  4 ++--
>   drivers/net/ethernet/intel/e100.c                |  4 ++--
>   drivers/net/ethernet/intel/e1000/e1000_ethtool.c |  4 ++--
>   drivers/net/ethernet/intel/e1000e/ethtool.c      |  4 ++--
>   drivers/net/ethernet/intel/e1000e/netdev.c       |  6 +++---
>   drivers/net/ethernet/intel/i40e/i40e_ethtool.c   |  6 +++---
>   drivers/net/ethernet/intel/i40e/i40e_main.c      | 16 ++++++++--------
>   drivers/net/ethernet/intel/i40e/i40e_ptp.c       |  2 +-
>   drivers/net/ethernet/intel/iavf/iavf_ethtool.c   |  6 +++---
>   drivers/net/ethernet/intel/igb/igb_ethtool.c     |  6 +++---
>   drivers/net/ethernet/intel/igb/igb_main.c        |  2 +-
>   drivers/net/ethernet/intel/igbvf/ethtool.c       |  4 ++--
>   drivers/net/ethernet/intel/ixgb/ixgb_ethtool.c   |  4 ++--
>   drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c |  6 +++---
>   drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c    |  2 +-
>   drivers/net/ethernet/intel/ixgbe/ixgbe_main.c    |  4 ++--
>   drivers/net/ethernet/intel/ixgbevf/ethtool.c     |  4 ++--
>   drivers/net/ethernet/jme.c                       |  6 +++---
>   drivers/net/ethernet/korina.c                    |  6 +++---
>   drivers/net/ethernet/marvell/mv643xx_eth.c       |  8 ++++----
>   drivers/net/ethernet/marvell/mvneta.c            |  6 +++---
>   drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c  |  6 +++---
>   .../marvell/octeontx2/nic/otx2_ethtool.c         |  8 ++++----
>   .../ethernet/marvell/prestera/prestera_ethtool.c |  4 ++--
>   drivers/net/ethernet/marvell/pxa168_eth.c        |  8 ++++----
>   drivers/net/ethernet/marvell/skge.c              |  6 +++---
>   drivers/net/ethernet/marvell/sky2.c              |  6 +++---
>   drivers/net/ethernet/mediatek/mtk_eth_soc.c      |  4 ++--
>   drivers/net/ethernet/mediatek/mtk_star_emac.c    |  2 +-
>   drivers/net/ethernet/mellanox/mlx4/en_ethtool.c  |  6 +++---
>   drivers/net/ethernet/mellanox/mlx4/fw.c          |  2 +-
>   .../net/ethernet/mellanox/mlx5/core/en_ethtool.c |  4 ++--
>   drivers/net/ethernet/mellanox/mlx5/core/en_rep.c |  2 +-
>   .../ethernet/mellanox/mlx5/core/ipoib/ethtool.c  |  2 +-
>   drivers/net/ethernet/mellanox/mlxsw/core.c       |  2 +-
>   drivers/net/ethernet/mellanox/mlxsw/minimal.c    |  4 ++--
>   .../ethernet/mellanox/mlxsw/spectrum_ethtool.c   |  6 +++---
>   drivers/net/ethernet/micrel/ks8851_common.c      |  6 +++---
>   drivers/net/ethernet/micrel/ksz884x.c            |  6 +++---
>   drivers/net/ethernet/microchip/enc28j60.c        |  6 +++---
>   drivers/net/ethernet/microchip/encx24j600.c      |  6 +++---
>   drivers/net/ethernet/microchip/lan743x_ethtool.c |  4 ++--
>   drivers/net/ethernet/myricom/myri10ge/myri10ge.c |  8 ++++----
>   drivers/net/ethernet/natsemi/natsemi.c           |  6 +++---
>   drivers/net/ethernet/natsemi/ns83820.c           |  6 +++---
>   drivers/net/ethernet/neterion/s2io.c             |  6 +++---
>   .../net/ethernet/netronome/nfp/nfp_net_ethtool.c |  6 +++---
>   drivers/net/ethernet/ni/nixge.c                  |  4 ++--
>   drivers/net/ethernet/nvidia/forcedeth.c          |  6 +++---
>   drivers/net/ethernet/nxp/lpc_eth.c               |  6 +++---
>   .../ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c  |  6 +++---
>   drivers/net/ethernet/packetengines/hamachi.c     |  6 +++---
>   drivers/net/ethernet/packetengines/yellowfin.c   |  6 +++---
>   .../ethernet/qlogic/netxen/netxen_nic_ethtool.c  |  6 +++---
>   drivers/net/ethernet/qlogic/qed/qed_int.c        |  2 +-
>   drivers/net/ethernet/qlogic/qede/qede_ethtool.c  |  4 ++--
>   drivers/net/ethernet/qlogic/qede/qede_main.c     |  2 +-
>   drivers/net/ethernet/qlogic/qla3xxx.c            |  6 +++---
>   .../net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c  |  6 +++---
>   drivers/net/ethernet/qualcomm/qca_debug.c        |  8 ++++----
>   drivers/net/ethernet/rdc/r6040.c                 |  6 +++---
>   drivers/net/ethernet/realtek/8139cp.c            |  6 +++---
>   drivers/net/ethernet/realtek/8139too.c           |  6 +++---
>   drivers/net/ethernet/realtek/r8169_main.c        |  6 +++---
>   drivers/net/ethernet/rocker/rocker_main.c        |  4 ++--
>   .../net/ethernet/samsung/sxgbe/sxgbe_ethtool.c   |  4 ++--
>   drivers/net/ethernet/sfc/efx.c                   |  2 +-
>   drivers/net/ethernet/sfc/efx_common.c            |  2 +-
>   drivers/net/ethernet/sfc/ethtool_common.c        |  6 +++---
>   drivers/net/ethernet/sfc/falcon/efx.c            |  4 ++--
>   drivers/net/ethernet/sfc/falcon/ethtool.c        |  8 ++++----
>   drivers/net/ethernet/sfc/falcon/falcon.c         |  2 +-
>   drivers/net/ethernet/sfc/falcon/nic.c            |  2 +-
>   drivers/net/ethernet/sfc/mcdi_mon.c              |  2 +-
>   drivers/net/ethernet/sfc/nic.c                   |  2 +-
>   drivers/net/ethernet/sfc/siena/efx.c             |  2 +-
>   drivers/net/ethernet/sfc/siena/efx_common.c      |  2 +-
>   drivers/net/ethernet/sfc/siena/ethtool_common.c  |  6 +++---
>   drivers/net/ethernet/sfc/siena/mcdi_mon.c        |  2 +-
>   drivers/net/ethernet/sfc/siena/nic.c             |  2 +-
>   drivers/net/ethernet/sgi/ioc3-eth.c              |  6 +++---
>   drivers/net/ethernet/sis/sis190.c                |  6 +++---
>   drivers/net/ethernet/sis/sis900.c                |  6 +++---
>   drivers/net/ethernet/smsc/epic100.c              |  6 +++---
>   drivers/net/ethernet/smsc/smc911x.c              |  6 +++---
>   drivers/net/ethernet/smsc/smc91c92_cs.c          |  4 ++--
>   drivers/net/ethernet/smsc/smc91x.c               |  6 +++---
>   drivers/net/ethernet/smsc/smsc911x.c             |  6 +++---
>   drivers/net/ethernet/smsc/smsc9420.c             |  6 +++---
>   drivers/net/ethernet/socionext/netsec.c          |  4 ++--
>   drivers/net/ethernet/socionext/sni_ave.c         |  4 ++--
>   .../net/ethernet/stmicro/stmmac/stmmac_ethtool.c |  8 ++++----
>   drivers/net/ethernet/sun/cassini.c               |  6 +++---
>   drivers/net/ethernet/sun/ldmvsw.c                |  4 ++--
>   drivers/net/ethernet/sun/niu.c                   |  6 +++---
>   drivers/net/ethernet/sun/sunbmac.c               |  4 ++--
>   drivers/net/ethernet/sun/sungem.c                |  6 +++---
>   drivers/net/ethernet/sun/sunhme.c                |  6 +++---
>   drivers/net/ethernet/sun/sunqe.c                 |  4 ++--
>   drivers/net/ethernet/sun/sunvnet.c               |  4 ++--
>   .../net/ethernet/synopsys/dwc-xlgmac-common.c    |  4 ++--
>   .../net/ethernet/synopsys/dwc-xlgmac-ethtool.c   |  6 +++---
>   drivers/net/ethernet/tehuti/tehuti.c             |  8 ++++----
>   drivers/net/ethernet/ti/am65-cpsw-ethtool.c      |  4 ++--
>   drivers/net/ethernet/ti/cpmac.c                  |  4 ++--
>   drivers/net/ethernet/ti/cpsw.c                   |  6 +++---
>   drivers/net/ethernet/ti/cpsw_new.c               |  6 +++---
>   drivers/net/ethernet/ti/davinci_emac.c           |  4 ++--
>   drivers/net/ethernet/ti/tlan.c                   |  6 +++---
>   drivers/net/ethernet/toshiba/ps3_gelic_net.c     |  4 ++--
>   .../net/ethernet/toshiba/spider_net_ethtool.c    |  8 ++++----
>   drivers/net/ethernet/toshiba/tc35815.c           |  6 +++---
>   drivers/net/ethernet/via/via-rhine.c             |  4 ++--
>   drivers/net/ethernet/via/via-velocity.c          |  8 ++++----
>   drivers/net/ethernet/wiznet/w5100.c              |  6 +++---
>   drivers/net/ethernet/wiznet/w5300.c              |  6 +++---
>   .../net/ethernet/xilinx/xilinx_axienet_main.c    |  4 ++--
>   drivers/net/ethernet/xilinx/xilinx_emaclite.c    |  2 +-
>   drivers/net/ethernet/xircom/xirc2ps_cs.c         |  2 +-
>   drivers/net/ethernet/xscale/ixp4xx_eth.c         |  4 ++--
>   199 files changed, 457 insertions(+), 457 deletions(-)
Tested-by: Naama Meir <naamax.meir at linux.intel.com>



More information about the Linux-mediatek mailing list