[PATCH] mfd: mt6370: add bounds checking to regmap_read/write functions

Andy Shevchenko andy.shevchenko at gmail.com
Thu Sep 8 00:54:02 PDT 2022


On Thu, Sep 8, 2022 at 9:57 AM Lee Jones <lee at kernel.org> wrote:
> On Mon, 22 Aug 2022, Dan Carpenter wrote:
> > On Fri, Aug 19, 2022 at 09:27:13AM +0300, Andy Shevchenko wrote:

...

> > I spent a long time looking at this code before I sent it and I've
> > spent a long time looking at it today.
> >
> > Smatch said that these values come from the user, but now it seems
> > less clear to me and I have rebuilt the DB so I don't have the same
> > information I was looking at earlier.
> >
> > So I can't see if these come from the user but neither can I find any
> > bounds checking.
>
> What's the consensus please?

>From my point of view it's not needed, and we may fix it later when a
real problem happens / revised analysis done. But OTOH it is harmless,
if you think it worth applying. I have no objections to the way Dan
and you choose.

-- 
With Best Regards,
Andy Shevchenko



More information about the Linux-mediatek mailing list