[PATCH v2 1/2] ASoC: mediatek: dt-bindings: modify machine bindings for two MICs case
Ajye Huang
ajye_huang at compal.corp-partner.google.com
Fri Oct 28 20:44:41 PDT 2022
Hi Mark Brown,
On Sat, Oct 29, 2022 at 2:44 AM Mark Brown <broonie at kernel.org> wrote:
>
> There was my thing about putting the names in DT too.
> @@ -72,6 +76,8 @@ examples:
> pinctrl-0 = <&aud_clk_mosi_off>;
> pinctrl-1 = <&aud_clk_mosi_on>;
>
> + dmic-gpios = <&pio 23 0>;
I think I added the pinctrl-name and pinctrl id in its example, to
make it easier for the user to understand , like below, what do you
think? thanks
examples:
- |
sound: mt8186-sound {
compatible = "mediatek,mt8186-mt6366-rt1019-rt5682s-sound";
mediatek,platform = <&afe>;
pinctrl-names = "aud_clk_mosi_off",
"aud_clk_mosi_on";
+ "aud_gpio_dmic_sec";
pinctrl-0 = <&aud_clk_mosi_off>;
pinctrl-1 = <&aud_clk_mosi_on>;
+ pinctrl-2 = <&aud_gpio_dmic_sec>;
+ dmic-gpios = <&pio 23 GPIO_ACTIVE_HIGH>;
headset-codec {
sound-dai = <&rt5682s>;
};
playback-codecs {
sound-dai = <&it6505dptx>,
<&rt1019p>;
};
};
More information about the Linux-mediatek
mailing list