[PATCH 6/8] arm64: dts: mt2712-evb: Fix usb vbus regulators unit names

Chunfeng Yun chunfeng.yun at mediatek.com
Thu Oct 13 19:43:55 PDT 2022


On Thu, 2022-10-13 at 17:22 +0200, AngeloGioacchino Del Regno wrote:
> Update the names to regulator-usb-p{0-3}-vbus to fix
> unit_address_vs_reg
> warnings for those.
> 
> Fixes: 1724f4cc5133 ("arm64: dts: Add USB3 related nodes for MT2712")
> Signed-off-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno at collabora.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> index 638908773706..d31a194124c9 100644
> --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> @@ -50,7 +50,7 @@ extcon_usb1: extcon_iddig1 {
>  		id-gpio = <&pio 14 GPIO_ACTIVE_HIGH>;
>  	};
>  
> -	usb_p0_vbus: regulator at 2 {
> +	usb_p0_vbus: regulator-usb-p0-vbus {
Can we modify dt-binding of fixed regulator instead of changing the
node name,
since all nodes using fixed regulator may need be changed.

>  		compatible = "regulator-fixed";
>  		regulator-name = "p0_vbus";
>  		regulator-min-microvolt = <5000000>;
> @@ -59,7 +59,7 @@ usb_p0_vbus: regulator at 2 {
>  		enable-active-high;
>  	};
>  
> -	usb_p1_vbus: regulator at 3 {
> +	usb_p1_vbus: regulator-usb-p1-vbus {
>  		compatible = "regulator-fixed";
>  		regulator-name = "p1_vbus";
>  		regulator-min-microvolt = <5000000>;
> @@ -68,7 +68,7 @@ usb_p1_vbus: regulator at 3 {
>  		enable-active-high;
>  	};
>  
> -	usb_p2_vbus: regulator at 4 {
> +	usb_p2_vbus: regulator-usb-p2-vbus {
>  		compatible = "regulator-fixed";
>  		regulator-name = "p2_vbus";
>  		regulator-min-microvolt = <5000000>;
> @@ -77,7 +77,7 @@ usb_p2_vbus: regulator at 4 {
>  		enable-active-high;
>  	};
>  
> -	usb_p3_vbus: regulator at 5 {
> +	usb_p3_vbus: regulator-usb-p3-vbus {
>  		compatible = "regulator-fixed";
>  		regulator-name = "p3_vbus";
>  		regulator-min-microvolt = <5000000>;




More information about the Linux-mediatek mailing list