答复: [PATCH -next 0/4] Fix PM disable depth imbalance in probe

zhangqilong zhangqilong3 at huawei.com
Sat Oct 8 06:00:06 PDT 2022


> On Thu, 29 Sep 2022 00:01:12 +0800, Zhang Qilong wrote:
> > The pm_runtime_enable will increase power disable depth. Thus a
> > pairing decrement is needed on the error handling path to keep it
> > balanced according to context. We fix it by moving pm_runtime_enable
> > to the endding of probe.
> >
> > Zhang Qilong (4):
> >   ASoC: wm8997: Fix PM disable depth imbalance in wm8997_probe
> >   ASoC: wm5110: Fix PM disable depth imbalance in wm5110_probe
> >   ASoC: wm5102: Fix PM disable depth imbalance in wm5102_probe
> >   ASoC: mt6660: Fix PM disable depth imbalance in mt6660_i2c_probe
> >
> > [...]
> 
> Applied to
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
> for-next

Hi, Mark

I have just found that, you have applied the old patch set, the newer patch
set (version V2) that reviewed by Charles is also been applied. It would be
better to keep the pm_runtime enables before the IRQ and component stuff.
Both of those could start triggering PM runtime events.

Now it have error pm_runtime_disable when error returns in wm8997_probe,
wm5110_probe, and wm5102_probe.

I will revert the old three patches to fix the problem and rebase the 4th patch.

Thanks,
Zhang

> 
> Thanks!
> 
> [1/4] ASoC: wm8997: Fix PM disable depth imbalance in wm8997_probe
>       commit: 41a736ac20602f64773e80f0f5b32cde1830a44a
> [2/4] ASoC: wm5110: Fix PM disable depth imbalance in wm5110_probe
>       commit: 86b46bf1feb83898d89a2b4a8d08d21e9ea277a7
> [3/4] ASoC: wm5102: Fix PM disable depth imbalance in wm5102_probe
>       commit: fcbb60820cd3008bb44334a0395e5e57ccb77329
> [4/4] ASoC: mt6660: Fix PM disable depth imbalance in
> mt6660_i2c_probe
>       commit: b73f11e895e140537e7f8c7251211ccd3ce0782b
> 
> All being well this means that it will be integrated into the linux-next tree
> (usually sometime in the next 24 hours) and sent to Linus during the next
> merge window (or sooner if it is a bug fix), however if problems are
> discovered then the patch may be dropped or reverted.
> 
> You may get further e-mails resulting from automated or manual testing
> and review of the tree, please engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
> 
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing patches
> will not be replaced.
> 
> Please add any relevant lists and maintainers to the CCs when replying to
> this mail.
> 
> Thanks,
> Mark


More information about the Linux-mediatek mailing list