[PATCH v2] dt-bindings: mfd: mt6370: fix the interrupt order of the charger in the example

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Wed Oct 5 01:33:16 PDT 2022


On 05/10/2022 10:14, ChiaEn Wu wrote:
> On Mon, Oct 3, 2022 at 11:34 PM Rob Herring <robh+dt at kernel.org> wrote:
>> This doesn't fix all the warnings. These still remain:
>>
>> /home/rob/proj/linux-dt/.build-arm64/Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb:
>> pmic at 34: indicator: 'color' is a required property
>>         From schema:
>> /home/rob/proj/linux-dt/Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml
>> /home/rob/proj/linux-dt/.build-arm64/Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb:
>> indicator: $nodename:0: 'indicator' does not match
>> '^multi-led(@[0-9a-f])?$'
>>         From schema:
>> /home/rob/proj/linux-dt/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml
> 
> Hi Rob,
> 
> In my opinion, the root cause of these warnings is the incorrect usage
> of 'allOf' in our LED indicator dts as follows,
> (https://lore.kernel.org/all/27df85c30277a171ae85ff6d5b7d867625765d0a.1663926551.git.chiaen_wu@richtek.com/)

Eh, my patch was merged in July... and yours from September still does
not use updated multi-led bindings. Was it even tested before sending?

Best regards,
Krzysztof




More information about the Linux-mediatek mailing list