[PATCH 08/12] ASoC: mediatek: mt8188: add platform driver

Trevor Wu (吳文良) Trevor.Wu at mediatek.com
Tue Oct 4 23:50:53 PDT 2022


Hi maintainers,

As I mentioned in the comment, this patch depends on a reviewing
series.
Should I remove the related code from this patch in case of the build
error?

Thanks,
Trevor

On Sat, 2022-10-01 at 17:17 +0800, kernel test robot wrote:
> Hi Trevor,
> 
> Thank you for the patch! Yet something to improve:
> 
> [auto build test ERROR on broonie-sound/for-next]
> [also build test ERROR on broonie-spi/for-next tiwai-sound/for-next
> linus/master v6.0-rc7 next-20220930]
> [If your patch is applied to the wrong git tree, kindly drop us a
> note.
> And when submitting patch, we suggest to use '--base' as documented
> in
> 
https://urldefense.com/v3/__https://git-scm.com/docs/git-format-patch*_base_tree_information__;Iw!!CTRNKA9wMg0ARbw!zH8i2KTwLCuHKyCuVMxGmO2ybS8oDN4t6suHxraLKrmfrn6SFI0bxxEdFfZ77PE7Rg$
>  ]
> 
> url:    
> https://urldefense.com/v3/__https://github.com/intel-lab-lkp/linux/commits/Trevor-Wu/ASoC-mediatek-Add-support-for-MT8188-SoC/20220930-230009__;!!CTRNKA9wMg0ARbw!zH8i2KTwLCuHKyCuVMxGmO2ybS8oDN4t6suHxraLKrmfrn6SFI0bxxEdFfY6vzwyJg$
>  
> base:   
> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git__;!!CTRNKA9wMg0ARbw!zH8i2KTwLCuHKyCuVMxGmO2ybS8oDN4t6suHxraLKrmfrn6SFI0bxxEdFfY9CuKUxg$
>   for-next
> config: s390-allyesconfig
> compiler: s390-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
>         wget 
> https://urldefense.com/v3/__https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross__;!!CTRNKA9wMg0ARbw!zH8i2KTwLCuHKyCuVMxGmO2ybS8oDN4t6suHxraLKrmfrn6SFI0bxxEdFfYvE9N_pg$
>   -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # 
> https://urldefense.com/v3/__https://github.com/intel-lab-lkp/linux/commit/65c941d291852582ccbe6a8196ff3b60fb4d1243__;!!CTRNKA9wMg0ARbw!zH8i2KTwLCuHKyCuVMxGmO2ybS8oDN4t6suHxraLKrmfrn6SFI0bxxEdFfb2BtdE-w$
>  
>         git remote add linux-review 
> https://urldefense.com/v3/__https://github.com/intel-lab-lkp/linux__;!!CTRNKA9wMg0ARbw!zH8i2KTwLCuHKyCuVMxGmO2ybS8oDN4t6suHxraLKrmfrn6SFI0bxxEdFfbWjiP_lw$
>  
>         git fetch --no-tags linux-review Trevor-Wu/ASoC-mediatek-Add-
> support-for-MT8188-SoC/20220930-230009
>         git checkout 65c941d291852582ccbe6a8196ff3b60fb4d1243
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0
> make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <lkp at intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    sound/soc/mediatek/mt8188/mt8188-afe-pcm.c: In function
> 'bus_protect_enable':
> > > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2649:16: error:
> > > 'MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP1' undeclared (first use in
> > > this function); did you mean
> > > 'MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1'?
> 
>     2649 |         mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP1;
>          |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>          |                MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1
>    sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2649:16: note: each
> undeclared identifier is reported only once for each function it
> appears in
> > > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2650:30: error:
> > > 'MT8188_TOP_AXI_PROT_EN_2_SET' undeclared (first use in this
> > > function); did you mean 'MT8186_TOP_AXI_PROT_EN_2_SET'?
> 
>     2650 |         regmap_write(regmap, MT8188_TOP_AXI_PROT_EN_2_SET,
> mask);
>          |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>          |                              MT8186_TOP_AXI_PROT_EN_2_SET
>    In file included from include/linux/regmap.h:20,
>                     from sound/soc/mediatek/mt8188/mt8188-afe-
> common.h:15,
>                     from sound/soc/mediatek/mt8188/mt8188-afe-
> pcm.c:24:
> > > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2652:48: error:
> > > 'MT8188_TOP_AXI_PROT_EN_2_STA' undeclared (first use in this
> > > function); did you mean 'MT8186_TOP_AXI_PROT_EN_2_STA'?
> 
>     2652 |         ret = regmap_read_poll_timeout(regmap,
> MT8188_TOP_AXI_PROT_EN_2_STA,
>          |                                                ^~~~~~~~~~~
> ~~~~~~~~~~~~~~~~~
>    include/linux/iopoll.h:46:28: note: in definition of macro
> 'read_poll_timeout'
>       46 |                 (val) = op(args); \
>          |                            ^~~~
>    sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2652:15: note: in
> expansion of macro 'regmap_read_poll_timeout'
>     2652 |         ret = regmap_read_poll_timeout(regmap,
> MT8188_TOP_AXI_PROT_EN_2_STA,
>          |               ^~~~~~~~~~~~~~~~~~~~~~~~
> > > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2659:16: error:
> > > 'MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP2' undeclared (first use in
> > > this function); did you mean
> > > 'MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1'?
> 
>     2659 |         mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP2;
>          |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>          |                MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1
>    sound/soc/mediatek/mt8188/mt8188-afe-pcm.c: In function
> 'bus_protect_disable':
>    sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2678:16: error:
> 'MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP2' undeclared (first use in this
> function); did you mean 'MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1'?
>     2678 |         mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP2;
>          |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>          |                MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1
> > > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2679:30: error:
> > > 'MT8188_TOP_AXI_PROT_EN_2_CLR' undeclared (first use in this
> > > function); did you mean 'MT8186_TOP_AXI_PROT_EN_2_CLR'?
> 
>     2679 |         regmap_write(regmap, MT8188_TOP_AXI_PROT_EN_2_CLR,
> mask);
>          |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>          |                              MT8186_TOP_AXI_PROT_EN_2_CLR
>    sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2681:48: error:
> 'MT8188_TOP_AXI_PROT_EN_2_STA' undeclared (first use in this
> function); did you mean 'MT8186_TOP_AXI_PROT_EN_2_STA'?
>     2681 |         ret = regmap_read_poll_timeout(regmap,
> MT8188_TOP_AXI_PROT_EN_2_STA,
>          |                                                ^~~~~~~~~~~
> ~~~~~~~~~~~~~~~~~
>    include/linux/iopoll.h:46:28: note: in definition of macro
> 'read_poll_timeout'
>       46 |                 (val) = op(args); \
>          |                            ^~~~
>    sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2681:15: note: in
> expansion of macro 'regmap_read_poll_timeout'
>     2681 |         ret = regmap_read_poll_timeout(regmap,
> MT8188_TOP_AXI_PROT_EN_2_STA,
>          |               ^~~~~~~~~~~~~~~~~~~~~~~~
>    sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2688:16: error:
> 'MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP1' undeclared (first use in this
> function); did you mean 'MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1'?
>     2688 |         mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP1;
>          |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>          |                MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1
> 
> 
> vim +2649 sound/soc/mediatek/mt8188/mt8188-afe-pcm.c
> 
>   2641	
>   2642	static int bus_protect_enable(struct regmap *regmap)
>   2643	{
>   2644		int ret;
>   2645		u32 val;
>   2646		u32 mask;
>   2647	
>   2648		val = 0;
> > 2649		mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP1;
> > 2650		regmap_write(regmap,
> > MT8188_TOP_AXI_PROT_EN_2_SET, mask);
> 
>   2651	
> > 2652		ret = regmap_read_poll_timeout(regmap,
> > MT8188_TOP_AXI_PROT_EN_2_STA,
> 
>   2653					       val, (val &
> mask) == mask,
>   2654					       MT8188_DELAY_US,
> MT8188_TIMEOUT_US);
>   2655		if (ret)
>   2656			return ret;
>   2657	
>   2658		val = 0;
> > 2659		mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP2;
> 
>   2660		regmap_write(regmap,
> MT8188_TOP_AXI_PROT_EN_2_SET, mask);
>   2661	
>   2662		ret = regmap_read_poll_timeout(regmap,
> MT8188_TOP_AXI_PROT_EN_2_STA,
>   2663					       val, (val &
> mask) == mask,
>   2664					       MT8188_DELAY_US,
> MT8188_TIMEOUT_US);
>   2665		if (ret)
>   2666			return ret;
>   2667	
>   2668		return 0;
>   2669	}
>   2670	
>   2671	static int bus_protect_disable(struct regmap *regmap)
>   2672	{
>   2673		int ret;
>   2674		u32 val;
>   2675		u32 mask;
>   2676	
>   2677		val = 0;
>   2678		mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP2;
> > 2679		regmap_write(regmap,
> > MT8188_TOP_AXI_PROT_EN_2_CLR, mask);
> 
>   2680	
>   2681		ret = regmap_read_poll_timeout(regmap,
> MT8188_TOP_AXI_PROT_EN_2_STA,
>   2682					       val, !(val &
> mask),
>   2683					       MT8188_DELAY_US,
> MT8188_TIMEOUT_US);
>   2684		if (ret)
>   2685			return ret;
>   2686	
>   2687		val = 0;
>   2688		mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP1;
>   2689		regmap_write(regmap,
> MT8188_TOP_AXI_PROT_EN_2_CLR, mask);
>   2690	
>   2691		ret = regmap_read_poll_timeout(regmap,
> MT8188_TOP_AXI_PROT_EN_2_STA,
>   2692					       val, !(val &
> mask),
>   2693					       MT8188_DELAY_US,
> MT8188_TIMEOUT_US);
>   2694		if (ret)
>   2695			return ret;
>   2696	
>   2697		return 0;
>   2698	}
>   2699	
> 


More information about the Linux-mediatek mailing list