Aw: Re: Re: [PATCH v6 11/11] arm64: dts: mt7986: add BPI-R3 nand/nor overlays

[Frank Wunderlich]

> Gesendet: Samstag, 26. November 2022 um 23:49 Uhr
> Von: "Rob Herring" <robh at kernel.org>
> An: "Frank Wunderlich" <frank-w at public-files.de>
> Cc: "Frank Wunderlich" <linux at fw-web.de>, linux-mediatek at lists.infradead.org
> Betreff: Re: Re: [PATCH v6 11/11] arm64: dts: mt7986: add BPI-R3 nand/nor overlays
> > > > >> >These need rules to apply them to the base dtb(s). You just need:
> > > > >> >
> > > > >> >full.dtb := base.dtb overlay.dtb
> > > > >> >dtb-y += full.dtb
> >
> > Hi,
> >
> > (removed most recipients to not spam all people with this)
> >
> > have now locally changed sd+emmc to overlays too and renamed to dtso...
> > tried also this way to (arch/arm64/boot/dts/mediatek/Makefile):
> >
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3.dtb
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd.dtbo
> >
> > mt7986a-bananapi-bpi-r3-sd-nand.dtb := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-sd.dtbo mt7986a-bananapi-bpi-r3-nand.dtbo
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nand.dtb
> >
> > does not work:
> >
> > make[3]: *** No rule to make target 'arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-sd-nand.dtb', needed by 'arch/arm64/boot/dts/mediatek/'.  Stop.
> >
> > any thoughts? but this way i will need all possible combinations, i guess best way it to leave the overlays themselves.
>
> You missed my correction:
>
> full-dtbs := base.dtb overlay.dtb
> dtb-y += full.dtb

Thanks,

using dash instead of dot and dtbs extension in full target works

mt7986a-bananapi-bpi-r3-sd-nand-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-sd.dtbo mt7986a-bananapi-bpi-r3-nand.dtbo
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nand.dtb

but i guess this is not the right way for mainline as this will add 5 more lines (10 in total for this single board)
to makefile to compile all 4 combinations.

i would send base dts and 4 overlays like above in next version if this is the right way.

regards Frank