[PATCH v2 9/9] wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices

Shayne Chen (陳軒丞) Shayne.Chen at mediatek.com
Tue Nov 22 01:04:30 PST 2022


On Mon, 2022-11-21 at 17:07 +0200, Kalle Valo wrote:
> Shayne Chen <shayne.chen at mediatek.com> writes:
> 
> > Add MediaTek new mac80211 driver mt7996 for Wi-Fi 7 (802.11be)
> > devices.
> > The driver first supports Filogic 680 PCI device, which is a Wi-Fi
> > 7
> > chipset supporting concurrent tri-band operation at 6 GHz, 5 GHz,
> > and
> > 2.4 GHz with 4x4 antennas on each band.
> > 
> > Currently, mt7996 only supports tri-band HE or older mode.
> > EHT mode and more variants of Filogic 680 support will be
> > introduced
> > in further patches.
> > 
> > Reviewed-by: Ryder Lee <ryder.lee at mediatek.com>
> > Co-developed-by: Peter Chiu <chui-hao.chiu at mediatek.com>
> > Signed-off-by: Peter Chiu <chui-hao.chiu at mediatek.com>
> > Co-developed-by: Bo Jiao <Bo.Jiao at mediatek.com>
> > Signed-off-by: Bo Jiao <Bo.Jiao at mediatek.com>
> > Co-developed-by: Howard Hsu <howard-yh.hsu at mediatek.com>
> > Signed-off-by: Howard Hsu <howard-yh.hsu at mediatek.com>
> > Co-developed-by: MeiChia Chiu <meichia.chiu at mediatek.com>
> > Signed-off-by: MeiChia Chiu <meichia.chiu at mediatek.com>
> > Co-developed-by: StanleyYP Wang <StanleyYP.Wang at mediatek.com>
> > Signed-off-by: StanleyYP Wang <StanleyYP.Wang at mediatek.com>
> > Co-developed-by: Money Wang <Money.Wang at mediatek.com>
> > Signed-off-by: Money Wang <Money.Wang at mediatek.com>
> > Co-developed-by: Evelyn Tsai <evelyn.tsai at mediatek.com>
> > Signed-off-by: Evelyn Tsai <evelyn.tsai at mediatek.com>
> > Signed-off-by: Shayne Chen <shayne.chen at mediatek.com>
> > ---
> >  drivers/net/wireless/mediatek/mt76/Kconfig    |    1 +
> >  drivers/net/wireless/mediatek/mt76/Makefile   |    1 +
> >  .../net/wireless/mediatek/mt76/mt7996/Kconfig |   12 +
> >  .../wireless/mediatek/mt76/mt7996/Makefile    |    6 +
> >  .../wireless/mediatek/mt76/mt7996/debugfs.c   |  851 ++++
> >  .../net/wireless/mediatek/mt76/mt7996/dma.c   |  360 ++
> >  .../wireless/mediatek/mt76/mt7996/eeprom.c    |  229 ++
> >  .../wireless/mediatek/mt76/mt7996/eeprom.h    |   75 +
> >  .../net/wireless/mediatek/mt76/mt7996/init.c  |  816 ++++
> >  .../net/wireless/mediatek/mt76/mt7996/mac.c   | 2468 ++++++++++++
> >  .../net/wireless/mediatek/mt76/mt7996/mac.h   |  398 ++
> >  .../net/wireless/mediatek/mt76/mt7996/main.c  | 1325 +++++++
> >  .../net/wireless/mediatek/mt76/mt7996/mcu.c   | 3428
> > +++++++++++++++++
> >  .../net/wireless/mediatek/mt76/mt7996/mcu.h   |  662 ++++
> >  .../net/wireless/mediatek/mt76/mt7996/mmio.c  |  385 ++
> >  .../wireless/mediatek/mt76/mt7996/mt7996.h    |  516 +++
> >  .../net/wireless/mediatek/mt76/mt7996/pci.c   |  222 ++
> >  .../net/wireless/mediatek/mt76/mt7996/regs.h  |  533 +++
> >  18 files changed, 12288 insertions(+)
> 
> This patch is too big, please split it. One patch per file is a good
> rule of thumb.
> 
> I did see some suspicious static variables in pci.c, but otherwise I
> basically skipped everything.
> 
Hi Kalle,

Thanks for your reminder.

I've splitted the big patch into smaller patches by functionality for
easier review.

Thanks,
Shayne


More information about the Linux-mediatek mailing list