[PATCH v2] PCI: mediatek-gen3: Fix refcount leak in mtk_pcie_init_irq_domains

Miaoqian Lin linmq006 at gmail.com
Sun May 29 23:48:06 PDT 2022


of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: 814cceebba9b ("PCI: mediatek-gen3: Add INTx support")
Signed-off-by: Miaoqian Lin <linmq006 at gmail.com>
---
changes in v2:
- move of_node_put(intc_node) right after irq_domain_add_linear to cover
normal path and error paths.

v1 link: https://lore.kernel.org/all/20220526110246.53502-1-linmq006@gmail.com/
---
 drivers/pci/controller/pcie-mediatek-gen3.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
index 3e8d70bfabc6..19a01daad304 100644
--- a/drivers/pci/controller/pcie-mediatek-gen3.c
+++ b/drivers/pci/controller/pcie-mediatek-gen3.c
@@ -598,6 +598,7 @@ static int mtk_pcie_init_irq_domains(struct mtk_gen3_pcie *pcie)
 
 	pcie->intx_domain = irq_domain_add_linear(intc_node, PCI_NUM_INTX,
 						  &intx_domain_ops, pcie);
+	of_node_put(intc_node);
 	if (!pcie->intx_domain) {
 		dev_err(dev, "failed to create INTx IRQ domain\n");
 		return -ENODEV;
-- 
2.25.1




More information about the Linux-mediatek mailing list