[PATCH v12 2/3] dts: arm64: mt8183: add Mediatek MDP3 nodes

[moudy.ho]

On Thu, 2022-03-17 at 16:26 +0100, AngeloGioacchino Del Regno wrote:
> Il 17/03/22 15:56, Moudy Ho ha scritto:
> > Add device nodes for Media Data Path 3 (MDP3) modules.
> > 
> > Signed-off-by: Moudy Ho <moudy.ho at mediatek.com>
> > ---
> >   arch/arm64/boot/dts/mediatek/mt8183.dtsi | 108
> > ++++++++++++++++++++++-
> >   1 file changed, 107 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > index fc6ac2a46324..eaa6dac7768b 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > @@ -1389,6 +1389,79 @@
> >   			mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX
> > 0 0x1000>;
> >   		};
> >   
> > +		mdp3_rdma0: mdp3_rdma0 at 14001000 {
> 
> Hello Moudy,
> 
> I know, this is already at v12 and I'm truly sorry for noticing this
> only now,
> but that's a bit critical to solve: you can't use underscores in node
> names (but
> you can do it in phandles).
> 
> Example:
> 
> mdp3_rdma0: mdp3_rdma0 at 14001000 <-- THIS IS WRONG
> 
> mdp3_rdma0: mdp3-rdma0 at 14001000 <--- THIS IS OK
> 
> of course, that's the same also for mdp3-rsz0 at ..... and the others.
> 
> Please fix this both here and in the yaml bindings in patch 1/3!
> 
> Sorry again,
> Angelo
> 

Hi Angelo,

Thanks for your help in checking and corresting the errors i haven't
found, I'll fix the relevant dts and bindings in the next version.

Thanks,
Moudy