[PATCH v1 1/4] pinctrl: add generic driving setup property on mt8192

[Guodong Liu]

-----Original Message-----
From: Nícolas F. R. A. Prado <nfraprado at collabora.com>
To: Guodong Liu <guodong.liu at mediatek.com>
Cc: Linus Walleij <linus.walleij at linaro.org>, Rob Herring <
robh+dt at kernel.org>, Matthias Brugger <matthias.bgg at gmail.com>, Sean
Wang <sean.wang at kernel.org>, Sean Wang <sean.wang at mediatek.com>,
Zhiyong Tao <zhiyong.tao at mediatek.com>, linux-gpio at vger.kernel.org, 
devicetree at vger.kernel.org, linux-arm-kernel at lists.infradead.org, 
linux-mediatek at lists.infradead.org, linux-kernel at vger.kernel.org, 
Project_Global_Chrome_Upstream_Group at mediatek.com
Subject: Re: [PATCH v1 1/4] pinctrl: add generic driving setup property
on mt8192
Date: Thu, 9 Jun 2022 14:16:58 -0400

Hi Guodong,

thank you for the patch.

On Wed, Jun 08, 2022 at 01:39:06PM +0800, Guodong Liu wrote:
> This patch provides generic driving setup, which support
> 2/4/6/8/10/12/14/16mA driving, original driver just set
> raw data setup setting when use drive-strength property

You should mention in the commit message that the dt-binding expects
that
drive-strength arguments be passed in mA, but the driver was expecting
raw
values. And that this commit changes the driver so that it is aligned
with the
binding.

Thanks,
Nícolas

will fix it in next version,thanks!
> 
> Signed-off-by: Guodong Liu <guodong.liu at mediatek.com>
> ---
>  drivers/pinctrl/mediatek/pinctrl-mt8192.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8192.c
> b/drivers/pinctrl/mediatek/pinctrl-mt8192.c
> index acccde9262ba..9faf7001369d 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mt8192.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mt8192.c
> @@ -1372,8 +1372,8 @@ static const struct mtk_pin_soc mt8192_data = {
>  	.gpio_m = 0,
>  	.bias_set_combo = mtk_pinconf_bias_set_combo,
>  	.bias_get_combo = mtk_pinconf_bias_get_combo,
> -	.drive_set = mtk_pinconf_drive_set_raw,
> -	.drive_get = mtk_pinconf_drive_get_raw,
> +	.drive_set	= mtk_pinconf_drive_set_rev1,
> +	.drive_get	= mtk_pinconf_drive_get_rev1,
>  	.adv_pull_get = mtk_pinconf_adv_pull_get,
>  	.adv_pull_set = mtk_pinconf_adv_pull_set,
>  	.adv_drive_get = mtk_pinconf_adv_drive_get,
> -- 
> 2.25.5
>