[PATCH] media: mediatek: vcodec: Drop platform_get_resource(IORESOURCE_IRQ)

AngeloGioacchino Del Regno angelogioacchino.delregno at collabora.com
Mon Jun 20 00:58:01 PDT 2022


Il 17/06/22 22:39, Nícolas F. R. A. Prado ha scritto:
> Commit a1a2b7125e10 ("of/platform: Drop static setup of IRQ resource
> from DT core") removed support for calling platform_get_resource(...,
> IORESOURCE_IRQ, ...) on DT-based drivers, but the probe() function of
> mtk-vcodec's encoder was still making use of it. This caused the encoder
> driver to fail probe.
> 
> Since the platform_get_resource() call was only being used to check for
> the presence of the interrupt (its returned resource wasn't even used)
> and platform_get_irq() was already being used to get the IRQ, simply
> drop the use of platform_get_resource(IORESOURCE_IRQ) and handle the
> failure of platform_get_irq(), to get the driver probing again.
> 
> Fixes: a1a2b7125e10 ("of/platform: Drop static setup of IRQ resource from DT core")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado at collabora.com>
> 
> ---
> Tested on mt8192-asurada-spherion.

Yep, that's totally necessary... Except the Fixes tag should be wrong here,
as you're not fixing that commit, but the mtk-vcodec driver in relation to
what's happening due to said commit.

I get that you're trying to tell everyone "this is an urgent fix", though,
and I agree that this *has to* get in v5.19 to avoid breaking this driver.

Finally, for the code:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno at collabora.com>

...but I think that you have to send a v2 that drops that Fixes tag.

Cheers,
Angelo



More information about the Linux-mediatek mailing list