[PATCH 1/3] dt-bindings: mediatek: add pinctrl definition for mt8188

[hui.liu]

On Tue, 2022-07-26 at 11:45 +0200, Krzysztof Kozlowski wrote:
> On 25/07/2022 12:10, hui.liu wrote:
> > On Fri, 2022-07-22 at 20:19 +0200, Krzysztof Kozlowski wrote:
> > > On 22/07/2022 03:40, hui.liu wrote:
> > > > Hi, Krzysztof
> > > > 
> > > > That's the comment about reg and reg-names description:
> > > > > > +  reg:
> > > > > > +    description: |
> > > > > > +      Physical address base for gpio base registers. There
> > > > > > are
> > > > > > 8
> > > > > > GPIO
> > > > > > +      physical address base in mt8188.
> > > > > 
> > > > > Redundant description, skip it. You should list the instead
> > > > > and
> > > > > describe
> > > > > each of it.
> > > > > 
> > > > > > +    maxItems: 8
> > > > > > +
> > > > > > +  reg-names:
> > > > > > +    description: |
> > > > > > +      Gpio base register names.
> > > > > 
> > > > > Redundant description, skip it.
> > > > > 
> > > > > > +    maxItems: 8
> > > > > 
> > > > > You need to list the items instead.
> > > > 
> > > > I plan to update reg and reg-names as the following:
> > > >   reg:
> > > >     description: |
> > > >       Physical address base for gpio base registers. There are
> > > > 6
> > > > different GPIO physical address bases in mt8188.
> > > >     minItems: 6
> > > >     maxItems: 6
> > > 
> > > You should rather have here items with description:
> > > items:
> > >  - description: what is it
> > >  - description: what is it
> > >  ....
> > > 
> > 
> > Hi Krzysztof,
> > 
> > I will list each items with description as follows, is it right?
> >   reg:
> >     description: |
> >       Physical address base for pinctrl base registers. There are 6
> > different physical address bases in mt8188.
> >       iocfg0 is gpio base address;
> >       iocfg_rm is io configuration
> > address for rm group;
> >       iocfg_lt is io configuration address for lt group;
> >       iocfg_lm
> > is io configuration address for mm group;
> >       iocfg_rt is io
> > configuration address for rt group;
> >       eint is eint base address.
> >     minItems: 6
> >     maxItems: 6
> 
> No, because it is not schema and you still keep here min/maxItems
> which
> are pointless in that case. Just read example-schema.
> 
> 
https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v5.19-rc8/source/Documentation/devicetree/bindings/example-schema.yaml*L63__;Iw!!CTRNKA9wMg0ARbw!3UAL3B4JBnRpnGEHm3ouXiks8-wfdn3HvAbNUytyTenGQinASn6nR35Hc8AJEYc$
>  
> 
Hi Krzysztof,

Thanks for you comment, I will reference the example-schema and update
the description in patch v2.