[PATCH v2 15/15] iio: inkern: fix coding style warnings
Andy Shevchenko
andy.shevchenko at gmail.com
Mon Jul 11 06:32:53 PDT 2022
On Mon, Jul 11, 2022 at 3:28 PM Biju Das <biju.das.jz at bp.renesas.com> wrote:
> > Subject: Re: [PATCH v2 15/15] iio: inkern: fix coding style warnings
> > On Mon, Jul 11, 2022 at 2:40 PM Nuno Sá <nuno.sa at analog.com> wrote:
...
> > > - if (name == NULL && channel_name == NULL)
> > > + if (!name && !channel_name)
> > > return ERR_PTR(-ENODEV);
> >
> > After this change in place, I think it's better to convert it to
> >
> > if (!(name || channel_name))
>
> It should be name && channel_name
>
> See below.
> (! ( 1 || 0)-> (! (1 && 1)
I didn't get what you are implying here. Please, check again what's in
the original code and what's being suggested.
> > which shows intentions clearer.
--
With Best Regards,
Andy Shevchenko
More information about the Linux-mediatek
mailing list