[RESEND PATCH v3 0/2] Input: mt6779-keypad - fix hw code logic and row/col selection
Mattijs Korpershoek
mkorpershoek at baylibre.com
Thu Jul 7 00:52:34 PDT 2022
Input: mt6779-keypad - fix hw code logic and row/col selection
This serie is the first follow-up on the mt6779-keypad in
order to enable it on the MediaTek mt8183-pumpkin board.
To fully enable it on mt8183-pumpkin, we still need:
* double key support
* dts changes
To ease up reviewing, I preferred sending this first.
The first patch fixes a logic bug based on the (non-public) datasheet
I have.
The second patch configures the keypad correctly in order to not
report bogus values.
Thank you,
Mattijs
Changes in v3:
* reworked row/column logic as discussed in [1]
* Dropped Angelo's review since patch 1 changed
Changes in v2:
* Simplified SEL_COL/ROW_MASK macros as suggested by Dmitry
* Added Angelo's Reviewed-by on patch 1
Mattijs Korpershoek (2):
Input: mt6779-keypad - match hardware matrix organization
Input: mt6779-keypad - implement row/column selection
drivers/input/keyboard/mt6779-keypad.c | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)
[1] https://lore.kernel.org/r/YpMDZORAlHmg/x/0@google.com
base-commit: c4bcc1b99b8b8acdfe673e4701a9c2acb6b8b2fb
--
2.34.1
More information about the Linux-mediatek
mailing list