[PATCH v15 11/16] drm/mediatek: dpi: move the yuv422_en_bit to SoC config
CK Hu
ck.hu at mediatek.com
Mon Jul 4 20:54:29 PDT 2022
Hi, Bo-Chen:
On Fri, 2022-07-01 at 11:58 +0800, Bo-Chen Chen wrote:
> From: Guillaume Ranquet <granquet at baylibre.com>
>
> Add flexibility by moving the yuv422 en bit to SoC specific config
Applied to mediatek-drm-next [1], thanks.
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next
Regards,
CK
>
> Signed-off-by: Guillaume Ranquet <granquet at baylibre.com>
> Signed-off-by: Bo-Chen Chen <rex-bc.chen at mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno at collabora.com>
> Reviewed-by: Rex-BC Chen <rex-bc.chen at mediatek.com>
> Reviewed-by: CK Hu <ck.hu at mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 70a83a3c0570..0b75a4ce8261 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -126,6 +126,7 @@ struct mtk_dpi_yc_limit {
> * (no shift).
> * @hvsize_mask: Mask of HSIZE and VSIZE mask (no shift).
> * @channel_swap_shift: Shift value of channel swap.
> + * @yuv422_en_bit: Enable bit of yuv422.
> */
> struct mtk_dpi_conf {
> unsigned int (*cal_factor)(int clock);
> @@ -139,6 +140,7 @@ struct mtk_dpi_conf {
> u32 dimension_mask;
> u32 hvsize_mask;
> u32 channel_swap_shift;
> + u32 yuv422_en_bit;
> };
>
> static void mtk_dpi_mask(struct mtk_dpi *dpi, u32 offset, u32 val,
> u32 mask)
> @@ -376,7 +378,8 @@ static void mtk_dpi_config_channel_swap(struct
> mtk_dpi *dpi,
>
> static void mtk_dpi_config_yuv422_enable(struct mtk_dpi *dpi, bool
> enable)
> {
> - mtk_dpi_mask(dpi, DPI_CON, enable ? YUV422_EN : 0, YUV422_EN);
> + mtk_dpi_mask(dpi, DPI_CON, enable ? dpi->conf->yuv422_en_bit :
> 0,
> + dpi->conf->yuv422_en_bit);
> }
>
> static void mtk_dpi_config_csc_enable(struct mtk_dpi *dpi, bool
> enable)
> @@ -822,6 +825,7 @@ static const struct mtk_dpi_conf mt8173_conf = {
> .dimension_mask = HPW_MASK,
> .hvsize_mask = HSIZE_MASK,
> .channel_swap_shift = CH_SWAP,
> + .yuv422_en_bit = YUV422_EN,
> };
>
> static const struct mtk_dpi_conf mt2701_conf = {
> @@ -836,6 +840,7 @@ static const struct mtk_dpi_conf mt2701_conf = {
> .dimension_mask = HPW_MASK,
> .hvsize_mask = HSIZE_MASK,
> .channel_swap_shift = CH_SWAP,
> + .yuv422_en_bit = YUV422_EN,
> };
>
> static const struct mtk_dpi_conf mt8183_conf = {
> @@ -849,6 +854,7 @@ static const struct mtk_dpi_conf mt8183_conf = {
> .dimension_mask = HPW_MASK,
> .hvsize_mask = HSIZE_MASK,
> .channel_swap_shift = CH_SWAP,
> + .yuv422_en_bit = YUV422_EN,
> };
>
> static const struct mtk_dpi_conf mt8192_conf = {
> @@ -862,6 +868,7 @@ static const struct mtk_dpi_conf mt8192_conf = {
> .dimension_mask = HPW_MASK,
> .hvsize_mask = HSIZE_MASK,
> .channel_swap_shift = CH_SWAP,
> + .yuv422_en_bit = YUV422_EN,
> };
>
> static int mtk_dpi_probe(struct platform_device *pdev)
More information about the Linux-mediatek
mailing list