[PATCH v2 3/5] mt76: mt7915: add support for MT7986

[Lorenzo Bianconi]

> > On Wed, 2022-01-12 at 14:35 +0100, Lorenzo Bianconi wrote:
> > > > 
> > > > @@ -302,6 +316,15 @@ struct mt7915_dev {
> > > >  		u8 table_mask;
> > > >  		u8 n_agrt;
> > > >  	} twt;
> > > > +
> > > > +	struct reset_control *rstc;
> > > > +	void __iomem *dcm;
> > > > +	void __iomem *sku;
> > > > +
> > > > +	struct {
> > > > +		bool is_7975;
> > > > +		bool is_7976;
> > > > +	} adie[MT7986_MAX_ADIE_NUM];
> > > 
> > > do we really need it? Can we just read data from chip when necessary?
> > > it is not
> > > access in the hot-path, right?
> > > I think it is easier and more readable.
> > 
> > Adie registers are inaccessible after wfsys power on so we need some
> > places to store chip configuration.
> > We will modify it to make it more readable.
> > + u32 adie;
> 
> what I mean is just continue reading these values after the first time (that is
> in common for both approaches).

ok, sorry I misread your reply. Anyway it seems to me we need these values just
in mt7986_wmac_enable() (or in routines called by mt7986_wmac_enable). Right?
If so maybe we can just store them in a local struct in mt7986_wmac_enable().
What do you think?

Regards,
Lorenzo

> 
> Regards,
> Lorenzo
> 
> > 
> > thanks,
> > Peter
> > 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mediatek/attachments/20220113/661e4d23/attachment-0001.sig>