[PATCH v7 0/3] force hsa hbp hfp packets multiple of lanenum to avoid screen shift
Neil Armstrong
narmstrong at baylibre.com
Wed Jan 12 01:31:36 PST 2022
Hi,
On 16/09/2021 00:31, Jitao Shi wrote:
> Changes since v6:
> - Add "bool hs_packet_end_aligned" in "struct mipi_dsi_device" to control the dsi aligned.
> - Config the "hs_packet_end_aligned" in ANX7725 .attach().
>
> Changes since v5:
> - Search the anx7625 compatible as flag to control dsi output aligned.
>
> Changes since v4:
> - Move "dt-bindings: drm/bridge: anx7625: add force_dsi_end_without_null" before
> "drm/mediatek: force hsa hbp hfp packets multiple of lanenum to avoid".
>
> - Retitle "dt-bindings: drm/bridge: anx7625: add force_dsi_end_without_null".
>
> Jitao Shi (3):
> drm/dsi: transer dsi hs packet aligned
> drm/mediatek: implment the dsi hs packets aligned
> drm/bridge: anx7625: config hs packets end aligned to avoid screen
> shift
>
> drivers/gpu/drm/bridge/analogix/anx7625.c | 1 +
> drivers/gpu/drm/mediatek/mtk_dsi.c | 10 ++++++++++
> include/drm/drm_mipi_dsi.h | 2 ++
> 3 files changed, 13 insertions(+)
>
It seems this patchset hasn't been viewed by DRM maintainers & reviewers at all.
Could you please resend a v8 with :
- a more complete explanation about this "hs_packet_end_aligned" in cover-letter and patch subject and why ?
Most of reviewers don't have access to MIPI spec, and we need an explanation about what are
the consequence of adding this flag.
- drm bridge maintainers in CC aswell, because almost only bridge maintainers/reviewers worry about DSI
- fix typos in subject & commit messsage like:
transer -> transfer
implment -> implement
These typos should have been fixed way before a V7 patchset version.
Furthermore, could you help us understanding the impact of adding hs_packet_end_aligned to these
bridge drivers when used with DSI transceivers drivers not supporting this flag ?
Can't you simply enable aligned packet whatever ? is it an issue if packet are aligned for some receivers ?
Neil
More information about the Linux-mediatek
mailing list