[PATCH] dt-bindings: phy: Add compatible for Mediatek MT8192

[Nícolas F. R. A. Prado]

Hi Allen,

thanks for the patch. Please see the comment below.

On Thu, Feb 17, 2022 at 09:56:20PM +0800, Allen-KH Cheng wrote:
> This commit adds dt-binding documentation of T-Phy for Mediatek MT8192 SoC
> Platform.

Commit messages should be in imperative [1]. I'd suggest the following message:

	Add MT8192 compatible to the Mediatek T-PHY dt-binding.

[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes

Also, the commit title would be better if it had the tag for the tphy file, like
this:

	dt-bindings: phy: mediatek,tphy: Add compatible for MT8192

Otherwise it's not clear that you're changing the T-PHY just from the title.

> 
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng at mediatek.com>

Other than that,

Reviewed-by: Nícolas F. R. A. Prado <nfraprado at collabora.com>

Thanks,
Nícolas

> ---
>  Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> index d279ba222316..7b2e1bc119be 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> @@ -81,6 +81,7 @@ properties:
>                - mediatek,mt7629-tphy
>                - mediatek,mt8183-tphy
>                - mediatek,mt8186-tphy
> +              - mediatek,mt8192-tphy
>            - const: mediatek,generic-tphy-v2
>        - items:
>            - enum:
> -- 
> 2.18.0
> 
>