[1/1] dt-bindings: pwm:Convert pwm-mtk-disp.txt format file to pwm-mtk-disp.yaml format file

[xinlei.lee]

On Mon, 2022-02-14 at 22:32 +0100, Krzysztof Kozlowski wrote:
> On 14/02/2022 15:01, xinlei.lee at mediatek.com wrote:
> > From: xinlei lee <xinlei.lee at mediatek.com>
> 
> Commit msg is needed.
> 
> Subject - missing space after ':' and it is too long. No need to say
> "format file" twice.
> 
> You miss "PATCH" in subject. Using `git format-patch` is the easiest
> way
> to create proper patches.
> 
> > 
> > Signed-off-by: xinlei lee <xinlei.lee at mediatek.com>
> > ---
> >  .../devicetree/bindings/pwm/pwm-mtk-disp.yaml      | 60
> > ++++++++++++++++++++++
> >  1 file changed, 60 insertions(+)
> 
> I do not see the conversion here... You only add one file. Where is
> the
> removal?
> 
> >  create mode 100644 Documentation/devicetree/bindings/pwm/pwm-mtk-
> > disp.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/pwm/pwm-mtk-
> > disp.yaml b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.yaml
> > new file mode 100644
> > index 0000000..2f1183e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.yaml
> 
> Let's name the file as with most bindings, so with vendor:
> "mediatek,pwm-disp.yaml"
> 
> > @@ -0,0 +1,60 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pwm/pwm-mtk-disp.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: mediatek PWM Controller Device Tree Bindings
> > +
> > +maintainers:
> > +  - Thierry Reding <thierry.reding at gmail.com>
> > +  - Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> > +  - Lee Jones <lee.jones at linaro.org>
> > +  - Rob Herring <robh+dt at kernel.org>
> > +
> 
> allOf referencing pwm.yaml
> 
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - mediatek,mt2701-disp-pwm
> > +      - mediatek,mt6595-disp-pwm
> > +      - mediatek,mt8173-disp-pwm
> > +      - mediatek,mt8183-disp-pwm
> > +      - mediatek,mt8186-disp-pwm
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    items:
> > +      - description: Main Clock
> > +      - description: Mm Clock
> > +
> 
> 
> This schema was not tested. Please run it against your DTS files
> (make
> dtbs_check). You need pwm-cells and power-domains. Maybe more...
> 
> > +  clock-names:
> > +    items:
> > +      - const: main
> > +      - const: mm
> 
> Blank line.
> 
> > +required:
> 
> "compatible" is required, put it first in the list.
> 
> > +  - reg
> > +  - interrupts
> > +  - clocks
> > +  - clock-names> +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    #include <dt-bindings/clock/mt8186-clk.h>
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> 
> Blank line.
> 
> > +    disp_pwm: disp_pwm0 at 1100e000 {
> 
> node name: "pwm" (generic as schema and devicetree specification ask
> for).
> 
> > +        compatible = "mediatek,mt8183-disp-pwm";
> > +        reg = <0x1100e000 0x1000>;
> > +        interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>;
> > +        clocks = <&topckgen CLK_TOP_DISP_PWM>,
> > +                 <&infracfg_ao CLK_INFRA_AO_DISP_PWM>;
> > +        clock-names = "main", "mm";
> > +        status = "okay";
> 
> No need for status.
> 
> > +    };
> > \ No newline at end of file
> 
> 
> Best regards,
> Krzysztof

Hi Krzysztof:

Thanks for your valuable comments, I will pay more attention to the
relevant details later, and I will revise according to your comments
and submit the next version in the near future.

Best Regards,
xinlei