[PATCH v3 net-next 1/2] net: ethernet: mtk_wed: fix some possible NULL pointer dereferences

Leon Romanovsky leon at kernel.org
Thu Dec 8 00:44:21 PST 2022


On Wed, Dec 07, 2022 at 03:04:54PM +0100, Lorenzo Bianconi wrote:
> Fix possible NULL pointer dereference in mtk_wed_detach routine checking
> wo pointer is properly allocated before running mtk_wed_wo_reset() and
> mtk_wed_wo_deinit().
> Even if it is just a theoretical issue at the moment check wo pointer is
> not NULL in mtk_wed_mcu_msg_update.
> Moreover, honor mtk_wed_mcu_send_msg return value in mtk_wed_wo_reset()
> 
> Fixes: 799684448e3e ("net: ethernet: mtk_wed: introduce wed wo support")
> Fixes: 4c5de09eb0d0 ("net: ethernet: mtk_wed: add configure wed wo support")
> Signed-off-by: Lorenzo Bianconi <lorenzo at kernel.org>
> ---
>  drivers/net/ethernet/mediatek/mtk_wed.c     | 13 ++++++++-----
>  drivers/net/ethernet/mediatek/mtk_wed_mcu.c |  3 +++
>  2 files changed, 11 insertions(+), 5 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro at nvidia.com>



More information about the Linux-mediatek mailing list