[PATCH net-next] net: ethernet: mtk_wed: fix possible deadlock if mtk_wed_wo_init fails

[Lorenzo Bianconi]

> On Wed, 7 Dec 2022 00:52:28 +0100 Lorenzo Bianconi wrote:
> > > FWIW, that does seem slightly better to me as well.
> > > Also - aren't you really fixing multiple issues here 
> > > (even if on the same error path)? The locking, 
> > > the null-checking and the change in mtk_wed_wo_reset()?  
> > 
> > wo NULL pointer issue was not hit before for the deadlock one (so I fixed them
> > in the same patch).
> > Do you prefer to split them in two patches? (wo null pointer fix first).
> 
> Yes, I think they are different issues even if once "covers" the other.
> I think it'd make the review / judgment easier.

ok, I will post v3 splitting them.

Regards,
Lorenzo

> 
> > I have posted v2 addressing Leon's comments but I need to post a v3 to add
> > missing WARN_ON.
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mediatek/attachments/20221207/235b665b/attachment.sig>