[PATCH v2,1/2] soc: mediatek: Add mmsys func to adapt to dpi output for MT8186

[xinlei.lee]

On Fri, 2022-08-19 at 14:54 -0400, Nícolas F. R. A. Prado wrote:
> Hi Xinlei,
> 
> On Fri, Aug 05, 2022 at 05:57:40PM +0800, xinlei.lee at mediatek.com
> wrote:
> > From: Xinlei Lee <xinlei.lee at mediatek.com>
> > 
> > Add mmsys func to manipulate dpi output format config for MT8186.
> 
> func -> function
> config -> configuration
> 
> > 
> > Signed-off-by: Jitao Shi <jitao.shi at mediatek.com>
> 
> Same thing about the co-developed-by.
> 
> > Signed-off-by: Xinlei Lee <xinlei.lee at mediatek.com>
> > 
> > ---
> >  drivers/soc/mediatek/mt8186-mmsys.h    | 1 +
> >  drivers/soc/mediatek/mtk-mmsys.c       | 8 ++++++++
> >  include/linux/soc/mediatek/mtk-mmsys.h | 3 +++
> >  3 files changed, 12 insertions(+)
> > 
> > diff --git a/drivers/soc/mediatek/mt8186-mmsys.h
> > b/drivers/soc/mediatek/mt8186-mmsys.h
> > index eb1ad9c37a9c..620c062e4893 100644
> > --- a/drivers/soc/mediatek/mt8186-mmsys.h
> > +++ b/drivers/soc/mediatek/mt8186-mmsys.h
> > @@ -3,6 +3,7 @@
> >  #ifndef __SOC_MEDIATEK_MT8186_MMSYS_H
> >  #define __SOC_MEDIATEK_MT8186_MMSYS_H
> >  
> > +#define MT8186_DPI_OUTPUT_FORMAT		0X400
> 
> 0x400
> 
> (lowercase "x")
> 
> >  #define MT8186_MMSYS_OVL_CON			0xF04
> >  #define MT8186_MMSYS_OVL0_CON_MASK			0x3
> >  #define MT8186_MMSYS_OVL0_2L_CON_MASK			0xC
> > diff --git a/drivers/soc/mediatek/mtk-mmsys.c
> > b/drivers/soc/mediatek/mtk-mmsys.c
> > index 9bbf0103b225..0e71a3296046 100644
> > --- a/drivers/soc/mediatek/mtk-mmsys.c
> > +++ b/drivers/soc/mediatek/mtk-mmsys.c
> > @@ -252,6 +252,14 @@ void mtk_mmsys_ddp_disconnect(struct device
> > *dev,
> >  }
> >  EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_disconnect);
> >  
> > +void mtk_mmsys_ddp_dpi_confing(struct device *dev, u32 mask, u32
> > val,
> 
> confing -> config
> 
> But I'd add something to the name to indicate it handles specifically
> the
> format:
> 
> mtk_mmsys_ddp_dpi_fmt_config
> 
> Thanks,
> Nícolas

Hi Nícolas:

Thanks for your careful review.
I will correct it in the next version:
1. Modify key nouns in the description;
2. Modify the label of jitao to Co-developed-by;
3. Macro definition address lowercase problem and function naming.

If there are no other questions, I will send out the second edition in
the near future.

Best Regards!
xinlei