[PATCH v5 2/2] arm64: dts: Add Mediatek SoC MT8186 dts and evaluation board and Makefile

[allen-kh.cheng]

Hi Miles,

On Wed, 2022-04-27 at 07:00 +0800, Miles Chen wrote:
> Hi Allen, 
> 
> > Add basic chip support for Mediatek MT8186.
> 
> s/Mediatek/MediaTek/
> 
ok

> > 
> > Signed-off-by: Allen-KH Cheng <Allen-KH.Cheng at mediatek.com>
> 
> ...snip...
> 
> > @@ -0,0 +1,232 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> 
> I think we should use GPL-2.0-only OR BSD-2-Clause for newly added
> dts files.
> i.e.,
> // SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> 
ok

> > +/*
> > + * Copyright (C) 2022 MediaTek Inc.
> > + */
> > +/dts-v1/;
> > +#include "mt8186.dtsi"
> > +
> > +/ {
> 
> 
> ..snip...
> 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8186.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8186.dtsi
> > new file mode 100644
> > index 000000000000..e8d8867412e3
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/mediatek/mt8186.dtsi
> > @@ -0,0 +1,932 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> 
> I think we should use GPL-2.0-only OR BSD-2-Clause for newly added
> dts files.
> i.e.,
> // SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> 

ok

> > +/*
> > + * Copyright (C) 2022 MediaTek Inc.
> > + * Author: Allen-KH Cheng <allenn-kh.cheng at mediatek.com>
> > + */
> > +/dts-v1/;
> > 
> 
> 
> thanks,
> Miles

I will correct those in next version.

Best regards,
Allen