[PATCH v13 3/3] media: platform: mtk-mdp3: add Mediatek MDP3 driver

moudy.ho moudy.ho at mediatek.com
Sun Apr 24 19:58:07 PDT 2022


On Tue, 2022-04-19 at 08:34 +0200, Hans Verkuil wrote:
> Hi Moudy Ho,
> 
> On 18/04/2022 04:22, Moudy Ho wrote:
> > This patch adds driver for Mediatek's Media Data Path ver.3 (MDP3).
> > It provides the following functions:
> >   color transform, format conversion, resize, crop, rotate, flip
> >   and additional image quality enhancement.
> > 
> > The MDP3 driver is mainly used for Google Chromebook products to
> > import the new architecture to set the HW settings as shown below:
> >   User -> V4L2 framework
> >     -> MDP3 driver -> SCP (setting calculations)
> >       -> MDP3 driver -> CMDQ (GCE driver) -> HW
> > 
> > Each modules' related operation control is sited in mtk-mdp3-comp.c
> > Each modules' register table is defined in file with "mdp_reg_"
> > prefix
> > GCE related API, operation control  sited in mtk-mdp3-cmdq.c
> > V4L2 m2m device functions are implemented in mtk-mdp3-m2m.c
> > Probe, power, suspend/resume, system level functions are defined in
> > mtk-mdp3-core.c
> > 
> > v4l2-compliance SHA: not available
> > , 32 bits, 32-bit time_t
> 
> This is an old v4l2-compliance (at least almost 2 years old based on
> this text).
> 
> Please compile v4l2-compliance from the v4l-utils git repo and make
> sure you
> see a proper SHA value here. I don't accept v4l2-compliance results
> without a
> valid SHA, since without that I can't tell which version you are
> testing with.
> 
> Regards,
> 
> 	Hans

Hi Hans,

Sorry for testing on the wrong version, the result of updating v4l-
utils is as follows:

v4l2-compliance 1.22.1, 32 bits, 32-bit time_t

Compliance test for mtk-mdp3 device /dev/video10:

Driver Info:
	Driver name      : mtk-mdp3
	Card type        : 14001000.mdp3-rdma0
	Bus info         : platform:mtk-mdp3
	Driver version   : 5.10.103
	Capabilities     : 0x84204000
		Video Memory-to-Memory Multiplanar
		Streaming
		Extended Pix Format
		Device Capabilities
	Device Caps      : 0x04204000
		Video Memory-to-Memory Multiplanar
		Streaming
		Extended Pix Format

Required ioctls:
	test VIDIOC_QUERYCAP: OK
	test invalid ioctls: OK

Allow for multiple opens:
	test second /dev/video10 open: OK
	test VIDIOC_QUERYCAP: OK
	test VIDIOC_G/S_PRIORITY: OK
	test for unlimited opens: OK

Debug ioctls:
	test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported)
	test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
	test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
	test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
	test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
	test VIDIOC_ENUMAUDIO: OK (Not Supported)
	test VIDIOC_G/S/ENUMINPUT: OK (Not Supported)
	test VIDIOC_G/S_AUDIO: OK (Not Supported)
	Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
	test VIDIOC_G/S_MODULATOR: OK (Not Supported)
	test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
	test VIDIOC_ENUMAUDOUT: OK (Not Supported)
	test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
	test VIDIOC_G/S_AUDOUT: OK (Not Supported)
	Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
	test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
	test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
	test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
	test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
	test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
	test VIDIOC_QUERYCTRL: OK
	test VIDIOC_G/S_CTRL: OK
	test VIDIOC_G/S/TRY_EXT_CTRLS: OK
	test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK
	test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
	Standard Controls: 4 Private Controls: 0

Format ioctls:
	test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
	test VIDIOC_G/S_PARM: OK (Not Supported)
	test VIDIOC_G_FBUF: OK (Not Supported)
	test VIDIOC_G_FMT: OK
	test VIDIOC_TRY_FMT: OK
	test VIDIOC_S_FMT: OK
	test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
	test Cropping: OK
	test Composing: OK
	test Scaling: OK

Codec ioctls:
	test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
	test VIDIOC_G_ENC_INDEX: OK (Not Supported)
	test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
	test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
	test VIDIOC_EXPBUF: OK
	test Requests: OK (Not Supported)
	test TIME32/64: OK

Test input 0:

Streaming ioctls:
	test read/write: OK (Not Supported)
	test blocking wait: OK

	Video Output Multiplanar: Frame #002
	Video Output Multiplanar: Frame #003
	Video Output Multiplanar: Frame #004
	Video Output Multiplanar: Frame #005
	Video Output Multiplanar: Frame #006
	Video Output Multiplanar: Frame #007
	Video Output Multiplanar: Frame #008
	Video Output Multiplanar: Frame #009
	Video Output Multiplanar: Frame #010
	Video Output Multiplanar: Frame #011
	Video Output Multiplanar: Frame #012
	Video Output Multiplanar: Frame #013
	Video Output Multiplanar: Frame #014
	Video Output Multiplanar: Frame #015
	Video Output Multiplanar: Frame #016
	Video Output Multiplanar: Frame #017
	Video Output Multiplanar: Frame #018
	Video Output Multiplanar: Frame #019
	Video Output Multiplanar: Frame #020
	Video Output Multiplanar: Frame #021
	Video Output Multiplanar: Frame #022
	Video Output Multiplanar: Frame #023
	Video Output Multiplanar: Frame #024
	Video Output Multiplanar: Frame #025
	Video Output Multiplanar: Frame #026
	Video Output Multiplanar: Frame #027
	Video Output Multiplanar: Frame #028
	Video Output Multiplanar: Frame #029
	Video Output Multiplanar: Frame #030
	Video Output Multiplanar: Frame #031
	Video Output Multiplanar: Frame #032
	Video Output Multiplanar: Frame #033
	Video Output Multiplanar: Frame #034
	Video Output Multiplanar: Frame #035
	Video Output Multiplanar: Frame #036
	Video Output Multiplanar: Frame #037
	Video Output Multiplanar: Frame #038
	Video Output Multiplanar: Frame #039
	Video Output Multiplanar: Frame #040
	Video Output Multiplanar: Frame #041
	Video Output Multiplanar: Frame #042
	Video Output Multiplanar: Frame #043
	Video Output Multiplanar: Frame #044
	Video Output Multiplanar: Frame #045
	Video Output Multiplanar: Frame #046
	Video Output Multiplanar: Frame #047
	Video Output Multiplanar: Frame #048
	Video Output Multiplanar: Frame #049
	Video Output Multiplanar: Frame #050
	Video Output Multiplanar: Frame #051
	Video Output Multiplanar: Frame #052
	Video Output Multiplanar: Frame #053
	Video Output Multiplanar: Frame #054
	Video Output Multiplanar: Frame #055
	Video Output Multiplanar: Frame #056
	Video Output Multiplanar: Frame #057
	Video Output Multiplanar: Frame #058
	Video Output Multiplanar: Frame #059
	                                                  
	Video Capture Multiplanar: Captured 58 buffers
	test MMAP (no poll): OK

	Video Output Multiplanar: Frame #002 (select)
	Video Output Multiplanar: Frame #003 (select)
	Video Output Multiplanar: Frame #004 (select)
	Video Output Multiplanar: Frame #005 (select)
	Video Output Multiplanar: Frame #006 (select)
	Video Output Multiplanar: Frame #007 (select)
	Video Output Multiplanar: Frame #008 (select)
	Video Output Multiplanar: Frame #009 (select)
	Video Output Multiplanar: Frame #010 (select)
	Video Output Multiplanar: Frame #011 (select)
	Video Output Multiplanar: Frame #012 (select)
	Video Output Multiplanar: Frame #013 (select)
	Video Output Multiplanar: Frame #014 (select)
	Video Output Multiplanar: Frame #015 (select)
	Video Output Multiplanar: Frame #016 (select)
	Video Output Multiplanar: Frame #017 (select)
	Video Output Multiplanar: Frame #018 (select)
	Video Output Multiplanar: Frame #019 (select)
	Video Output Multiplanar: Frame #020 (select)
	Video Output Multiplanar: Frame #021 (select)
	Video Output Multiplanar: Frame #022 (select)
	Video Output Multiplanar: Frame #023 (select)
	Video Output Multiplanar: Frame #024 (select)
	Video Output Multiplanar: Frame #025 (select)
	Video Output Multiplanar: Frame #026 (select)
	Video Output Multiplanar: Frame #027 (select)
	Video Output Multiplanar: Frame #028 (select)
	Video Output Multiplanar: Frame #029 (select)
	Video Output Multiplanar: Frame #030 (select)
	Video Output Multiplanar: Frame #031 (select)
	Video Output Multiplanar: Frame #032 (select)
	Video Output Multiplanar: Frame #033 (select)
	Video Output Multiplanar: Frame #034 (select)
	Video Output Multiplanar: Frame #035 (select)
	Video Output Multiplanar: Frame #036 (select)
	Video Output Multiplanar: Frame #037 (select)
	Video Output Multiplanar: Frame #038 (select)
	Video Output Multiplanar: Frame #039 (select)
	Video Output Multiplanar: Frame #040 (select)
	Video Output Multiplanar: Frame #041 (select)
	Video Output Multiplanar: Frame #042 (select)
	Video Output Multiplanar: Frame #043 (select)
	Video Output Multiplanar: Frame #044 (select)
	Video Output Multiplanar: Frame #045 (select)
	Video Output Multiplanar: Frame #046 (select)
	Video Output Multiplanar: Frame #047 (select)
	Video Output Multiplanar: Frame #048 (select)
	Video Output Multiplanar: Frame #049 (select)
	Video Output Multiplanar: Frame #050 (select)
	Video Output Multiplanar: Frame #051 (select)
	Video Output Multiplanar: Frame #052 (select)
	Video Output Multiplanar: Frame #053 (select)
	Video Output Multiplanar: Frame #054 (select)
	Video Output Multiplanar: Frame #055 (select)
	Video Output Multiplanar: Frame #056 (select)
	Video Output Multiplanar: Frame #057 (select)
	Video Output Multiplanar: Frame #058 (select)
	Video Output Multiplanar: Frame #059 (select)
	                                                  
	Video Capture Multiplanar: Captured 58 buffers
	test MMAP (select): OK

	Video Output Multiplanar: Frame #002 (epoll)
	Video Output Multiplanar: Frame #003 (epoll)
	Video Output Multiplanar: Frame #004 (epoll)
	Video Output Multiplanar: Frame #005 (epoll)
	Video Output Multiplanar: Frame #006 (epoll)
	Video Output Multiplanar: Frame #007 (epoll)
	Video Output Multiplanar: Frame #008 (epoll)
	Video Output Multiplanar: Frame #009 (epoll)
	Video Output Multiplanar: Frame #010 (epoll)
	Video Output Multiplanar: Frame #011 (epoll)
	Video Output Multiplanar: Frame #012 (epoll)
	Video Output Multiplanar: Frame #013 (epoll)
	Video Output Multiplanar: Frame #014 (epoll)
	Video Output Multiplanar: Frame #015 (epoll)
	Video Output Multiplanar: Frame #016 (epoll)
	Video Output Multiplanar: Frame #017 (epoll)
	Video Output Multiplanar: Frame #018 (epoll)
	Video Output Multiplanar: Frame #019 (epoll)
	Video Output Multiplanar: Frame #020 (epoll)
	Video Output Multiplanar: Frame #021 (epoll)
	Video Output Multiplanar: Frame #022 (epoll)
	Video Output Multiplanar: Frame #023 (epoll)
	Video Output Multiplanar: Frame #024 (epoll)
	Video Output Multiplanar: Frame #025 (epoll)
	Video Output Multiplanar: Frame #026 (epoll)
	Video Output Multiplanar: Frame #027 (epoll)
	Video Output Multiplanar: Frame #028 (epoll)
	Video Output Multiplanar: Frame #029 (epoll)
	Video Output Multiplanar: Frame #030 (epoll)
	Video Output Multiplanar: Frame #031 (epoll)
	Video Output Multiplanar: Frame #032 (epoll)
	Video Output Multiplanar: Frame #033 (epoll)
	Video Output Multiplanar: Frame #034 (epoll)
	Video Output Multiplanar: Frame #035 (epoll)
	Video Output Multiplanar: Frame #036 (epoll)
	Video Output Multiplanar: Frame #037 (epoll)
	Video Output Multiplanar: Frame #038 (epoll)
	Video Output Multiplanar: Frame #039 (epoll)
	Video Output Multiplanar: Frame #040 (epoll)
	Video Output Multiplanar: Frame #041 (epoll)
	Video Output Multiplanar: Frame #042 (epoll)
	Video Output Multiplanar: Frame #043 (epoll)
	Video Output Multiplanar: Frame #044 (epoll)
	Video Output Multiplanar: Frame #045 (epoll)
	Video Output Multiplanar: Frame #046 (epoll)
	Video Output Multiplanar: Frame #047 (epoll)
	Video Output Multiplanar: Frame #048 (epoll)
	Video Output Multiplanar: Frame #049 (epoll)
	Video Output Multiplanar: Frame #050 (epoll)
	Video Output Multiplanar: Frame #051 (epoll)
	Video Output Multiplanar: Frame #052 (epoll)
	Video Output Multiplanar: Frame #053 (epoll)
	Video Output Multiplanar: Frame #054 (epoll)
	Video Output Multiplanar: Frame #055 (epoll)
	Video Output Multiplanar: Frame #056 (epoll)
	Video Output Multiplanar: Frame #057 (epoll)
	Video Output Multiplanar: Frame #058 (epoll)
	Video Output Multiplanar: Frame #059 (epoll)
	                                                  
	Video Capture Multiplanar: Captured 58 buffers
	test MMAP (epoll): OK
	test USERPTR (no poll): OK (Not Supported)
	test USERPTR (select): OK (Not Supported)
	test DMABUF: Cannot test, specify --expbuf-device

Total for mtk-mdp3 device /dev/video10: 53, Succeeded: 53, Failed: 0,
Warnings: 0

If there is any lack of information, please let me know.

Thanks,
Moudy




More information about the Linux-mediatek mailing list