[PATCH 3/7] clk: mediatek: reset: Merge and revise reset register function
Chen-Yu Tsai
wenst at chromium.org
Tue Apr 19 00:26:10 PDT 2022
On Mon, Apr 18, 2022 at 9:22 PM Rex-BC Chen <rex-bc.chen at mediatek.com> wrote:
>
> Merge the reset register function of v1 and v2 into one function.
> - Input the version number to determine which version we will use.
> - Add return value of reset register function for error handling.
Please do this in a separate patch. Also you are adding error messages
for when of_clk_add_provider() fails, which is not mentioned either.
Most of these platform drivers require a good cleanup of their error
handling anyway. It might be a good idea to tackle them later. Or if
they look the same, you could try using coccinelle to do a bulk cleanup.
Thanks
ChenYu
> - Rename reset register function to "mtk_clk_register_rst_ctrl"
More information about the Linux-mediatek
mailing list