[PATCH 09/14] mips: dts: ralink: mt7621: use the new compatible string for MT7621 pinctrl

[Arınç ÜNAL]

On 13/04/2022 18:27, Krzysztof Kozlowski wrote:
> On 13/04/2022 08:07, Arınç ÜNAL wrote:
>> Use the new compatible string "ralink,mt7621-pinctrl" for the Ralink MT7621
>> pinctrl subdriver on mt7621.dtsi.
>>
>> Signed-off-by: Arınç ÜNAL <arinc.unal at arinc9.com>
>> ---
>>   arch/mips/boot/dts/ralink/mt7621.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
>> index 3222684915ac..ee2ec78c8952 100644
>> --- a/arch/mips/boot/dts/ralink/mt7621.dtsi
>> +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
>> @@ -151,7 +151,7 @@ spi0: spi at b00 {
>>   	};
>>   
>>   	pinctrl: pinctrl {
>> -		compatible = "ralink,rt2880-pinmux";
>> +		compatible = "ralink,mt7621-pinctrl";
> 
> The change is non-bisectable and causes issues all other users of DT
> (other projects, systems etc). This is discouraged in general, so you
> should describe it. The commit msg lacks answer to the main question:
> Why? You focused only on what you are doing, but why you are doing is
> actually more important for such change.

As it's seen on any other pinctrl subdriver that calls code from a main 
driver, each subdriver needs to have a different compatible string. We 
don't want the same compatible string to match a different subdriver's 
pinmux data as it's not for our SoC.

I'll add what I typed above to the commit log.

Arınç