[PATCH 1/1] arm64: dts: mt8192: Add mmc device nodes

[allen-kh.cheng]

Hi Angelo,
On Mon, 2022-04-04 at 14:36 +0200, AngeloGioacchino Del Regno wrote:
> Il 01/04/22 07:30, Allen-KH Cheng ha scritto:
> > Add mmc nodes for mt8192 SoC.
> > 
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng at mediatek.com>
> > ---
> >   arch/arm64/boot/dts/mediatek/mt8192.dtsi | 33
> > ++++++++++++++++++++++++
> >   1 file changed, 33 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > index a6da7b04b9d4..23eb92057cb9 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > @@ -989,6 +989,39 @@
> >   			compatible = "mediatek,mt8192-msdc";
> >   			reg = <0 0x11f60000 0 0x1000>;
> >   			#clock-cells = <1>;
> > +			status = "disabled";
> > +		};
> > +
> 
> Hello!
> Please explain the reason (in the commit message) why you're
> disabling the
> mediatek,mt8192-msdc node, which was enabled before this change.
> 
> Also, introducing the mtk-sd controller at the same address as the
> mt8192-msdc
> clock controller will produce a warning...
> 
> Thanks,
> Angelo

In mt8192.
mmc driver would directly  write/read register(11f60000) to control
clock configure.

Alos there is no other module using msdc: clock-controller.

I would remove the clock-controller entirely and explain in commit
description.

Thanks,
Allen