[PATCH v2] media: mediatek: vcodec: Fix v4l2 compliance decoder cmd test fail

Yunfei Dong yunfei.dong at mediatek.com
Fri Apr 1 01:13:02 PDT 2022


Will return -EINVAL using standard framework api when test stateless
decoder with cmd VIDIOC_(TRY)DECODER_CMD.

Using another return value to adjust v4l2 compliance test for user
driver(GStreamer/Chrome) won't use decoder cmd.

Fixes: 8cdc3794b2e3 ("media: mtk-vcodec: vdec: support stateless API")
Signed-off-by: Yunfei Dong <yunfei.dong at mediatek.com>
---
changes compared with v1:
- add Fixes: tag
---
 drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
index 3859e4c651c6..69b0e797d342 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
@@ -51,8 +51,7 @@ static int vidioc_try_decoder_cmd(struct file *file, void *priv,
 
 	/* Use M2M stateless helper if relevant */
 	if (ctx->dev->vdec_pdata->uses_stateless_api)
-		return v4l2_m2m_ioctl_stateless_try_decoder_cmd(file, priv,
-								cmd);
+		return -ENOTTY;
 	else
 		return v4l2_m2m_ioctl_try_decoder_cmd(file, priv, cmd);
 }
-- 
2.18.0




More information about the Linux-mediatek mailing list