[PATCH v7 2/7] i2c: mediatek: Reset the handshake signal between i2c and dma
Wolfram Sang
wsa at the-dreams.de
Fri Oct 1 23:30:37 PDT 2021
> +#define I2C_CLR_DEBUGCTR 0x0000
Hmm, I don't think that a macro to clear a register helps readability...
> + mtk_i2c_writew(i2c, I2C_CLR_DEBUGCTR, OFFSET_DEBUGCTRL);
...
+ mtk_i2c_writew(i2c, 0, OFFSET_DEBUGCTRL);
looks good to me. Anyhow, it is not a big issue. Let me know if you want
to change it or keep it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mediatek/attachments/20211002/71adbb33/attachment-0001.sig>
More information about the Linux-mediatek
mailing list