[PATCH] mt76: mt7921: fix timestamp check in tx_status
Lorenzo Bianconi
lorenzo at kernel.org
Mon Nov 22 07:14:42 PST 2021
> From: Deren Wu <deren.wu at mediatek.com>
>
> Should keep SKBs only if timeout timestamp is still after jiffies.
> Otherwise, report tx status and drop it direclty.
>
> Fixes: bd1e3e7b693c ("mt76: introduce packet_id idr")
> Signed-off-by: Deren Wu <deren.wu at mediatek.com>
> ---
I guess this fix should go in wireless-drivers tree.
Acked-by: Lorenzo Bianconi <lorenzo at kernel.org>
> drivers/net/wireless/mediatek/mt76/tx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/tx.c b/drivers/net/wireless/mediatek/mt76/tx.c
> index 11719ef034d8..6b8c9dc80542 100644
> --- a/drivers/net/wireless/mediatek/mt76/tx.c
> +++ b/drivers/net/wireless/mediatek/mt76/tx.c
> @@ -173,7 +173,7 @@ mt76_tx_status_skb_get(struct mt76_dev *dev, struct mt76_wcid *wcid, int pktid,
> if (!(cb->flags & MT_TX_CB_DMA_DONE))
> continue;
>
> - if (!time_is_after_jiffies(cb->jiffies +
> + if (time_is_after_jiffies(cb->jiffies +
> MT_TX_STATUS_SKB_TIMEOUT))
> continue;
> }
> --
> 2.18.0
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mediatek/attachments/20211122/13066b1a/attachment.sig>
More information about the Linux-mediatek
mailing list