[PATCH 1/1] soc: mediatek: Remove redundant error printing in mtk_mutex_probe()

Zhen Lei thunder.leizhen at huawei.com
Tue May 11 02:57:14 PDT 2021


When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: Hulk Robot <hulkci at huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen at huawei.com>
---
 drivers/soc/mediatek/mtk-mutex.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c
index 2e4bcc300576f5c..9e6aee24c92cfd0 100644
--- a/drivers/soc/mediatek/mtk-mutex.c
+++ b/drivers/soc/mediatek/mtk-mutex.c
@@ -481,10 +481,8 @@ static int mtk_mutex_probe(struct platform_device *pdev)
 
 	regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	mtx->regs = devm_ioremap_resource(dev, regs);
-	if (IS_ERR(mtx->regs)) {
-		dev_err(dev, "Failed to map mutex registers\n");
+	if (IS_ERR(mtx->regs))
 		return PTR_ERR(mtx->regs);
-	}
 
 	platform_set_drvdata(pdev, mtx);
 
-- 
2.26.0.106.g9fadedd





More information about the Linux-mediatek mailing list