[PATCH] arm64: dts: mt8183: kukui: use generic pin configs for i2c pins

Chen-Yu Tsai wenst at chromium.org
Wed Jun 30 00:29:16 PDT 2021


On Wed, Jun 30, 2021 at 3:27 PM Chen-Yu Tsai <wenst at chromium.org> wrote:
>
> On Wed, Jun 30, 2021 at 11:55 AM Hsin-Yi Wang <hsinyi at chromium.org> wrote:
> >
> > mt8183 i2c pins don't support PUPD register, so change to use generic
> > pin configs instead of let it fail and fallback.
> >
> > Signed-off-by: Hsin-Yi Wang <hsinyi at chromium.org>
>
> Reviewed-by: Chen-Yu Tsai <wenst at chromium.org>

You might also want:

Fixes: cd894e274b74 ("arm64: dts: mt8183: Add krane-sku176 board")

> On a side note, the `mediatek,pull-up-adv` property probably should be
> merged into `bias-pull-up` with an argument.



More information about the Linux-mediatek mailing list