[PATCH v1 2/2] net: ethernet: mtk_eth_soc: Support custom ifname
code at reto-schneider.ch
Sun Jun 13 06:53:50 PDT 2021
On 13.06.21 14:20, Russell King (Oracle) wrote:
> Please don't use strncpy() - this is a good example why strncpy() is bad
> * strncpy - Copy a length-limited, C-string
> * @dest: Where to copy the string to
> * @src: Where to copy the string from
> * @count: The maximum number of bytes to copy
> * The result is not %NUL-terminated if the source exceeds
> * @count bytes.
> Consequently, if "name" is IFNAMSIZ bytes or longer,
> eth->netdev[id]->name will not be NUL terminated, and subsequent use
> will run off the end of the string. strscpy() is safer to use here.
Thanks a lot for finding this (embarrassing mistake) and pointing me in
the right direction (did dot know about strscpy).
Will send v2 soon.
More information about the Linux-mediatek