[PATCH] arm64: ftrace: don't dereference a probably invalid address

Mark-PK Tsai mark-pk.tsai at mediatek.com
Sun Jun 6 20:23:30 PDT 2021

Address in __mcount_loc may be invalid if somthing goes wrong.
On our arm64 platform, the bug in recordmcount make kernel
crash in ftrace_init().


Return -EFAULT if we are dealing with out-of-range condition
to prevent dereference the invalid address in ftrace_bug(),
then the kernel can disable ftrace safely for problematic

Signed-off-by: Mark-PK Tsai <mark-pk.tsai at mediatek.com>
 arch/arm64/kernel/ftrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/ftrace.c b/arch/arm64/kernel/ftrace.c
index b5d3ddaf69d9..98bec8445a58 100644
--- a/arch/arm64/kernel/ftrace.c
+++ b/arch/arm64/kernel/ftrace.c
@@ -201,7 +201,7 @@ int ftrace_make_nop(struct module *mod, struct dyn_ftrace *rec,
 			if (WARN_ON(!mod))
-				return -EINVAL;
+				return -EFAULT;

More information about the Linux-mediatek mailing list