[PATCH] pinctrl: mediatek: move bit assignment

Linus Walleij linus.walleij at linaro.org
Sun Jun 6 15:49:01 PDT 2021


On Wed, Jun 2, 2021 at 2:34 PM Matthias Brugger <matthias.bgg at gmail.com> wrote:

> > -
> > +     bit = BIT(pin & 0xf);
>
> I see this is already applied to linux-next, but I think the correct fix is to move
> bit = BIT(offset & pctl->devdata->mode_mask);
> just before calling regmap_write(...)
>
> I can provide a patch for that, if you want. Just let me know if I should base
> it against linux-next or if you will drop the fix proposed by you?

Just patch it in my tree, I merged more stuff on top and this
was just my quickfix to get next working.

Yours,
Linus Walleij



More information about the Linux-mediatek mailing list