[PATCH v2] isoc: mediatek: Fix dereference of null pointer while alloc fail

Mark Brown broonie at kernel.org
Fri Dec 17 09:00:26 PST 2021


On Sat, Dec 18, 2021 at 12:52:20AM +0800, Jiasheng Jiang wrote:

>  		clk[i] = devm_clk_get(&pdev->dev, clk_names[i]);
> +		if (IS_ERR(clk[i]))
> +			return -ENOMEM;

As I and IIRC someone else pointed out there is an error code encoded in
the pointer if IS_ERR() is true, we should use that error code.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mediatek/attachments/20211217/6caa4168/attachment.sig>


More information about the Linux-mediatek mailing list