[PATCH] mt76: mt7921: reduce log severity levels for informative messages

Tzung-Bi Shih tzungbi at google.com
Fri Dec 10 01:19:50 PST 2021


On Fri, Dec 10, 2021 at 4:49 PM Kalle Valo <kvalo at kernel.org> wrote:
>
> Tzung-Bi Shih <tzungbi at google.com> writes:
[...]
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> > index 6ada1ebe7d68..99b144fd8db5 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> > @@ -882,7 +882,7 @@ static int mt7921_load_firmware(struct mt7921_dev *dev)
> >       dev->mt76.hw->wiphy->wowlan = &mt76_connac_wowlan_support;
> >  #endif /* CONFIG_PM */
> >
> > -     dev_err(dev->mt76.dev, "Firmware init done\n");
> > +     dev_info(dev->mt76.dev, "Firmware init done\n");
>
> Shouldn't that be a debug message? Hard to see how's that useful in
> normal operation.

I thought the message was an indicator of "the firmware is loaded
completely".  Sent v2 to use dbg instead.



More information about the Linux-mediatek mailing list