[PATCH v2] mt76: mt7915: add LED support

[kernel test robot]

Hi Ryder,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on wireless-drivers/master v5.14-rc7 next-20210827]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ryder-Lee/mt76-mt7915-add-LED-support/20210828-043133
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: i386-randconfig-a005-20210827 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4e1a164d7bd53653f79decc121afe784d2fde0a7)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/9f1e6ed6d46d979a1331b2ca536fd79e0cac8760
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ryder-Lee/mt76-mt7915-add-LED-support/20210828-043133
        git checkout 9f1e6ed6d46d979a1331b2ca536fd79e0cac8760
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/mediatek/mt76/mt7915/init.c:195:6: warning: variable 'delta_on' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
           if (*delay_on)
               ^~~~~~~~~
   drivers/net/wireless/mediatek/mt76/mt7915/init.c:200:34: note: uninitialized use occurs here
           mt7915_led_set_config(led_cdev, delta_on, delta_off);
                                           ^~~~~~~~
   drivers/net/wireless/mediatek/mt76/mt7915/init.c:195:2: note: remove the 'if' if its condition is always true
           if (*delay_on)
           ^~~~~~~~~~~~~~
   drivers/net/wireless/mediatek/mt76/mt7915/init.c:190:14: note: initialize the variable 'delta_on' to silence this warning
           u16 delta_on, delta_off;
                       ^
                        = 0
>> drivers/net/wireless/mediatek/mt76/mt7915/init.c:197:6: warning: variable 'delta_off' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
           if (*delay_off)
               ^~~~~~~~~~
   drivers/net/wireless/mediatek/mt76/mt7915/init.c:200:44: note: uninitialized use occurs here
           mt7915_led_set_config(led_cdev, delta_on, delta_off);
                                                     ^~~~~~~~~
   drivers/net/wireless/mediatek/mt76/mt7915/init.c:197:2: note: remove the 'if' if its condition is always true
           if (*delay_off)
           ^~~~~~~~~~~~~~~
   drivers/net/wireless/mediatek/mt76/mt7915/init.c:190:25: note: initialize the variable 'delta_off' to silence this warning
           u16 delta_on, delta_off;
                                  ^
                                   = 0
   2 warnings generated.


vim +195 drivers/net/wireless/mediatek/mt76/mt7915/init.c

   194	
 > 195		if (*delay_on)
   196			delta_on = TO_HW_TICK(*delay_on);
 > 197		if (*delay_off)
   198			delta_off = TO_HW_TICK(*delay_off);
   199	
   200		mt7915_led_set_config(led_cdev, delta_on, delta_off);
   201	
   202		return 0;
   203	}
   204	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 41460 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mediatek/attachments/20210828/31805a24/attachment-0001.gz>