[RFC PATCH] usb: xhci-mtk: handle bandwidth table rollover

Greg Kroah-Hartman gregkh at linuxfoundation.org
Mon Aug 9 02:11:42 PDT 2021


On Mon, Aug 09, 2021 at 04:59:29PM +0800, Ikjoon Jang wrote:
> xhci-mtk has 64 slots for periodic bandwidth calculations and each
> slot represents byte budgets on a microframe. When an endpoint's
> allocation sits on the boundary of the table, byte budgets' slot
> should be rolled over but the current implementation doesn't.
> 
> This patch applies a 6 bits mask to the microframe index to handle
> its rollover 64 slots and prevent out-of-bounds array access.
> 
> Signed-off-by: Ikjoon Jang <ikjn at chromium.org>
> ---
> 
>  drivers/usb/host/xhci-mtk-sch.c | 79 +++++++++------------------------
>  drivers/usb/host/xhci-mtk.h     |  1 +
>  2 files changed, 23 insertions(+), 57 deletions(-)

Why is this "RFC"?  What needs to be addressed in this change before it
can be accepted?

thanks,

greg k-h



More information about the Linux-mediatek mailing list