[PATCH v2 3/4] spi: mediatek: modify set_cs_timing callback

Mark Brown broonie at kernel.org
Tue Aug 3 12:30:49 PDT 2021


On Tue, Aug 03, 2021 at 09:20:19PM +0300, Andy Shevchenko wrote:
> On Tue, Aug 3, 2021 at 1:42 PM Mason Zhang <Mason.Zhang at mediatek.com> wrote:

> > +       inactive = inactive ? inactive : 1;

> All of these can be simplified by using ?: (short ternary) form.

Please don't, if anything just don't use the ternery operator at all for
things like this - it doesn't help with legibility.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mediatek/attachments/20210803/214f5362/attachment.sig>


More information about the Linux-mediatek mailing list