[RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match returning -EPROBE_DEFER

Alice Guo (OSS) alice.guo at oss.nxp.com
Mon Apr 19 07:40:46 BST 2021


> -----Original Message-----
> From: Dominique MARTINET <dominique.martinet at atmark-techno.com>
> Sent: 2021年4月19日 12:49
> To: Alice Guo (OSS) <alice.guo at oss.nxp.com>
> Cc: gregkh at linuxfoundation.org; rafael at kernel.org; Horia Geanta
> <horia.geanta at nxp.com>; Aymen Sghaier <aymen.sghaier at nxp.com>;
> herbert at gondor.apana.org.au; davem at davemloft.net; tony at atomide.com;
> geert+renesas at glider.be; mturquette at baylibre.com; sboyd at kernel.org;
> vkoul at kernel.org; peter.ujfalusi at gmail.com; a.hajda at samsung.com;
> narmstrong at baylibre.com; robert.foss at linaro.org; airlied at linux.ie;
> daniel at ffwll.ch; khilman at baylibre.com; tomba at kernel.org; jyri.sarha at iki.fi;
> joro at 8bytes.org; will at kernel.org; mchehab at kernel.org;
> ulf.hansson at linaro.org; adrian.hunter at intel.com; kishon at ti.com;
> kuba at kernel.org; linus.walleij at linaro.org; Roy Pledge <roy.pledge at nxp.com>;
> Leo Li <leoyang.li at nxp.com>; ssantosh at kernel.org; matthias.bgg at gmail.com;
> edubezval at gmail.com; j-keerthy at ti.com; balbi at kernel.org;
> linux at prisktech.co.nz; stern at rowland.harvard.edu; wim at linux-watchdog.org;
> linux at roeck-us.net; linux-kernel at vger.kernel.org; linux-crypto at vger.kernel.org;
> linux-omap at vger.kernel.org; linux-renesas-soc at vger.kernel.org;
> linux-clk at vger.kernel.org; dmaengine at vger.kernel.org;
> dri-devel at lists.freedesktop.org; linux-amlogic at lists.infradead.org;
> linux-arm-kernel at lists.infradead.org; iommu at lists.linux-foundation.org;
> linux-media at vger.kernel.org; linux-mmc at vger.kernel.org;
> netdev at vger.kernel.org; linux-phy at lists.infradead.org;
> linux-gpio at vger.kernel.org; linuxppc-dev at lists.ozlabs.org;
> linux-staging at lists.linux.dev; linux-mediatek at lists.infradead.org;
> linux-pm at vger.kernel.org; linux-usb at vger.kernel.org;
> linux-watchdog at vger.kernel.org
> Subject: Re: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match
> returning -EPROBE_DEFER
> 
> First comment overall for the whole serie:
> Since it is the solution I had suggested when I reported the problem[1] I have no
> qualm on the approach, comments for individual patches follow.
> 
> [1] http://lore.kernel.org/r/YGGZJjAxA1IO+/VU@atmark-techno.com
> 
> 
> Alice Guo (OSS) wrote on Mon, Apr 19, 2021 at 12:27:20PM +0800:
> > From: Alice Guo <alice.guo at nxp.com>
> >
> > In i.MX8M boards, the registration of SoC device is later than caam
> > driver which needs it. Caam driver needs soc_device_match to provide
> > -EPROBE_DEFER when no SoC device is registered and no
> > early_soc_dev_attr.
> 
> This patch should be last in the set: you can't have soc_device_match return an
> error before its callers handle it.
> 
> > Signed-off-by: Alice Guo <alice.guo at nxp.com>
> 
> As the one who reported the problem I would have been appreciated being at
> least added to Ccs... I only happened to notice you posted this by chance.

Sorry. I will Cc you next time.

> There is also not a single Fixes tag -- I believe this commit should have Fixes:
> 7d981405d0fd ("soc: imx8m: change to use platform driver") but I'm not sure
> how such tags should be handled in case of multiple patches fixing something.

I only mentioned "soc: imx8m: change to use platform driver" in cover letter.
If it is acceptable to make such a modification, I will send non-RFC and add Fixes tag.

Best Regards,
Alice

> --
> Dominique


More information about the Linux-mediatek mailing list