[PATCH v2] net: dsa: mt7530: Add some return-value checks

[Landen Chao]

On Thu, 2020-09-24 at 14:11 +0100, Alex Dewar wrote:
> On 2020-09-24 13:13, Landen Chao wrote:
> > Hi Alex,
> >
> > Thanks for your patch. By linux/scripts/checkpatch.pl
> >
> > On Sun, 2020-09-20 at 03:28 +0800, Alex Dewar wrote:
> > [..]
> >> @@ -1631,9 +1635,11 @@ mt7530_setup(struct dsa_switch *ds)
> >>   		mt7530_rmw(priv, MT7530_PCR_P(i), PCR_MATRIX_MASK,
> >>   			   PCR_MATRIX_CLR);
> >>   
> >> -		if (dsa_is_cpu_port(ds, i))
> >> -			mt753x_cpu_port_enable(ds, i);
> >> -		else
> >> +		if (dsa_is_cpu_port(ds, i)) {
> >> +			ret = mt753x_cpu_port_enable(ds, i);
> >> +			if (ret)
> >> +				return ret;
> >> +		} else
> >>   			mt7530_port_disable(ds, i);
> > CHECK: braces {} should be used on all arms of this statement
> > CHECK: Unbalanced braces around else statement
> >>   
> >>   		/* Enable consistent egress tag */
> >> @@ -1785,9 +1791,11 @@ mt7531_setup(struct dsa_switch *ds)
> >>   
> >>   		mt7530_set(priv, MT7531_DBG_CNT(i), MT7531_DIS_CLR);
> >>   
> >> -		if (dsa_is_cpu_port(ds, i))
> >> -			mt753x_cpu_port_enable(ds, i);
> >> -		else
> >> +		if (dsa_is_cpu_port(ds, i)) {
> >> +			ret = mt753x_cpu_port_enable(ds, i);
> >> +			if (ret)
> >> +				return ret;
> >> +		} else
> >>   			mt7530_port_disable(ds, i);
> > CHECK: braces {} should be used on all arms of this statement
> > CHECK: Unbalanced braces around else statement
> >
> > [..]
> > regards landen
> Hi Landen,
> 
> Sorry about this... I usually run checkpatch over my patches. Would you 
> like me to send a separate fix or a v3?
> 
> Best,
> Alex
Hi Alex,

Because v2 has not been merged yet, could you help to fix it in v3?

regards landen