[PATCH 2/2] usb: mtu3: fix NULL pointer dereference

Chunfeng Yun chunfeng.yun at mediatek.com
Tue Jun 30 03:28:59 EDT 2020


On Mon, 2020-06-29 at 10:00 +0200, Markus Elfring wrote:
> > Some pointers are dereferenced before successful checks.
> 
> I suggest to reconsider and improve the change description.
> 
> * Would a null pointer dereference be possible only with the variables “mep”
>   and “mreq” in the implementation of the function “mtu3_gadget_dequeue”?
> 
> * How do you think about to adjust any more variable initialisations?
Yes, I'll do it if need, thanks

> 
> * Will it become helpful to add the tag “Fixes” to the commit message?
Maybe needn't

> 
> Regards,
> Markus



More information about the Linux-mediatek mailing list