[v3 PATCH] usb: gadget: bdc: use readl_poll_timeout() to simplify code

Chunfeng Yun chunfeng.yun at mediatek.com
Wed Jul 22 02:51:20 EDT 2020


On Tue, 2020-07-21 at 12:42 +0300, Felipe Balbi wrote:
> Hi,
> 
> Chunfeng Yun <chunfeng.yun at mediatek.com> writes:
> > Use readl_poll_timeout() to poll register status
> >
> > Cc: Florian Fainelli <f.fainelli at gmail.com>
> > Signed-off-by: Chunfeng Yun <chunfeng.yun at mediatek.com>
> > Reviewed-by: Florian Fainelli <f.fainelli at gmail.com>
> 
> I had a lot of trouble to apply this patch, could you avoid base64
> encoding on the patch body next time?
Sorry for inconvenience.


I usually use Source Insight 3.5 or Vim to edit the code, sometimes use
Beyond Compare to compare patches, their default encoding is UTF-8 or
ANSI. Not sure which tool would use base64 encoding, maybe introduced
when I copy email address from Win7 with Chinese (used to receive email)
into Win10 with English (used to sent email/patch). 


Can you tell me which lines are base64 encoding in this patch?


The patch's encoding is ANSI, I'll convert it into UTF-8 and resend it,
please try it again.

> 
> Thanks
> 



More information about the Linux-mediatek mailing list