opp: Modify opp API, dev_pm_opp_get_freq(), find freq in opp, even it is disabled

Stephen Boyd sboyd at kernel.org
Tue Jul 21 04:15:47 EDT 2020


Quoting Andrew-sh.Cheng (2020-07-20 01:55:26)
> From: "Andrew-sh.Cheng" <andrew-sh.cheng at mediatek.com>
> 
> Modify dev_pm_opp_get_freq() to return freqeuncy
> even this opp item is not available.
> So that we can get the information of disable opp items.
> 
> Signed-off-by: Andrew-sh.Cheng <andrew-sh.cheng at mediatek.com>
> ---
>  drivers/opp/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/opp/core.c b/drivers/opp/core.c
> index eed42d6b2e6b..5213e0462382 100644
> --- a/drivers/opp/core.c
> +++ b/drivers/opp/core.c
> @@ -118,7 +118,7 @@ EXPORT_SYMBOL_GPL(dev_pm_opp_get_voltage);
>   */
>  unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp)
>  {
> -       if (IS_ERR_OR_NULL(opp) || !opp->available) {
> +       if (IS_ERR_OR_NULL(opp)) {

I wonder why we even have this check. Seems like the caller deserves an
oops in this case instead of a small pr_err().

>                 pr_err("%s: Invalid parameters\n", __func__);
>                 return 0;



More information about the Linux-mediatek mailing list