[PATCH 1/4] mfd: mt6360: Refactor and fix code style
Lee Jones
lee.jones at linaro.org
Mon Jul 13 02:51:10 EDT 2020
On Fri, 10 Jul 2020, Matthias Brugger wrote:
>
>
> On 07/07/2020 12:30, Gene Chen wrote:
> > From: Gene Chen <gene_chen at richtek.com>
> >
> > Rearrange include file.
> > Remove brackets around raw numbers.
> > Indicate sub-dev compatible name by using "-"
> > Combine mt6360 pmic/ldo resouces into mt6360 regulator resources.
> > Rename mt6360_pmu_data by mt6360_data.
> > Rename mt6360_pmu by mt6360.
>
> That seems like a lot of cosmetics. Why is this needed?
> If you think that's needed it should be split up in different commits, each
> explaining in the commit message why you do that.
Agreed. This set is still not broken up enough.
Please place each logical change into its own patch for review.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
More information about the Linux-mediatek
mailing list