[RFT v2 21/29] memory: omap-gpmc: Remove GPMC_SET_ONE_CD_MAX macro for safety

[Krzysztof Kozlowski]

On Fri, Jul 24, 2020 at 09:40:30AM +0200, Krzysztof Kozlowski wrote:
> The GPMC_SET_ONE_CD_MAX macro uses return statement and variable 'cs'
> coming from called scope.  This is not a good practice.  Also
> checkpatch complained:
> 
>     WARNING: Macros with flow control statements should be avoided
>     ERROR: Macros starting with if should be enclosed by a do - while
>         loop to avoid possible if/else logic defects
> 
> Since GPMC_SET_ONE_CD_MAX macro just calls one function, it can be open
> coded.  The difference with original code is that function will exit on
> error not after every register set, but after a group of sets.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk at kernel.org>
> 
> ---
> 

Applied.

Best regards,
Krzysztof