[GIT,PULL] mediatek drm fixes for 5.2

CK Hu ck.hu at mediatek.com
Thu Jun 13 19:06:00 PDT 2019


On Thu, 2019-06-13 at 10:27 +0200, Daniel Vetter wrote:
> On Thu, Jun 13, 2019 at 02:31:18PM +0800, CK Hu wrote:
> > Hi, Daniel:
> > 
> > On Wed, 2019-06-12 at 18:25 +0200, Daniel Vetter wrote:
> > > On Wed, Jun 12, 2019 at 03:51:08PM +0800, CK Hu wrote:
> > > > Hi Dave, Daniel:
> > > > 
> > > > This include unbind error fix, clock control flow refinement, and PRIME
> > > > mmap with page offset.
> > > > 
> > > > Regards,
> > > > CK
> > > > 
> > > > The following changes since commit
> > > > a188339ca5a396acc588e5851ed7e19f66b0ebd9:
> > > > 
> > > >   Linux 5.2-rc1 (2019-05-19 15:47:09 -0700)
> > > > 
> > > > are available in the Git repository at:
> > > > 
> > > >   https://github.com/ckhu-mediatek/linux.git-tags.git
> > > > mediatek-drm-fixes-5.2
> > > 
> > > For next time around, please make this a signed annotated tag. annotated
> > > because then it's less typing for me, and signed because it's on a server
> > > we don't necessarily trust.
> > 
> > OK, I'd make a signed annotated tag in next time.
> > 
> > > 
> > > > 
> > > > for you to fetch changes up to 2458d9d6d94be982b917e93c61a89b4426f32e31:
> > > > 
> > > >   drm/mediatek: call mtk_dsi_stop() after mtk_drm_crtc_atomic_disable()
> > > > (2019-06-04 09:54:42 +0800)
> > > > 
> > > > ----------------------------------------------------------------
> > > > Hsin-Yi Wang (5):
> > > >       drm/mediatek: fix unbind functions
> > > >       drm/mediatek: unbind components in mtk_drm_unbind()
> > > >       drm/mediatek: call drm_atomic_helper_shutdown() when unbinding
> > > > driver
> > > >       drm/mediatek: clear num_pipes when unbind driver
> > > >       drm/mediatek: call mtk_dsi_stop() after
> > > > mtk_drm_crtc_atomic_disable()
> > > > 
> > > > Yongqiang Niu (2):
> > > >       drm/mediatek: adjust ddp clock control flow
> > > >       drm/mediatek: respect page offset for PRIME mmap calls
> > > 
> > > You might want to look into all the recently added helpers for mmap, I
> > > don't think mtk does anything special here.
> > 
> > If you mean using drm_gem_prime_mmap as the implementation of
> > drm_driver->gem_prime_mmap, I think we have discussed in [1] that
> > mediatek drm still need its own implementation.
> > 
> > [1] https://patchwork.kernel.org/patch/10657007/
> 
> Yeah for reusing the overall helpers that's clear, but
> drm_gem_prime_gem_mmap should work for any gem based driver. It doesn't
> require you to use specific helpers at all.
> 
> I'm wondering about this since I'm looking right now into this area, and
> it looks like we could just make drm_gem_prime_mmap the default and rip
> out all the custom driver implementations.

OK, I find that drm_gem_prime_mmap() call driver->fops->mmap(), so the
customization could be done in driver->fops->mmap and let
drm_driver.gem_prime_mmap to be drm_gem_prime_mmap. I would try to do
so.

Regards,
CK

> -Daniel
> 
> > 
> > Regards,
> > CK
> > 
> > > 
> > > 
> > > > 
> > > >  drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 30
> > > > ++++++------------------------
> > > >  drivers/gpu/drm/mediatek/mtk_drm_drv.c  |  8 +++-----
> > > >  drivers/gpu/drm/mediatek/mtk_drm_gem.c  |  7 ++++++-
> > > >  drivers/gpu/drm/mediatek/mtk_dsi.c      | 12 +++++++++++-
> > > >  4 files changed, 26 insertions(+), 31 deletions(-)
> > > 
> > > Pulled, thanks.
> > > -Daniel
> > > 
> > > > 
> > > > _______________________________________________
> > > > dri-devel mailing list
> > > > dri-devel at lists.freedesktop.org
> > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > > 
> > 
> > 
> 





More information about the Linux-mediatek mailing list